템플릿 CRUD에 태그 및 카테고리 추가, 카테고리 CRUD #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: zangsu <[email protected]>
Co-authored-by: zangsu <[email protected]>
Co-authored-by: zangsu <[email protected]>
Co-authored-by: zangsu <[email protected]>
템플릿 생성 기능 리팩토링
- 존재하고 있습니다 -> 존재합니다 로 변경 - 응답에 중복된 이름에 대한 예외 추가
카테고리 기능 구현
Co-authored-by: zangsu <[email protected]>
Co-authored-by: zangsu <[email protected]>
Co-authored-by: zangsu <[email protected]>
Co-authored-by: zangsu <[email protected]>
jminkkk
previously approved these changes
Aug 5, 2024
backend/src/main/java/codezap/template/dto/request/CreateTemplateRequest.java
Outdated
Show resolved
Hide resolved
zangsu
previously approved these changes
Aug 5, 2024
kyum-q
previously approved these changes
Aug 5, 2024
zeus6768
requested changes
Aug 5, 2024
backend/src/main/java/codezap/category/controller/CategoryController.java
Outdated
Show resolved
Hide resolved
| import codezap.global.validation.ValidationGroups.SizeCheckGroup; | ||
| import io.swagger.v3.oas.annotations.media.Schema; | ||
|
|
||
| public record UpdateCategoryRequest( |
| @Service | ||
| public class CategoryService { | ||
|
|
||
| public static final int DEFAULT_CATEGORY = 1; |
There was a problem hiding this comment.
Suggested change
| public static final int DEFAULT_CATEGORY = 1; | |
| private static final long DEFAULT_CATEGORY_ID = 1; |
backend/src/main/java/codezap/template/service/TemplateService.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/codezap/template/service/TemplateService.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/codezap/template/service/TemplateService.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/codezap/template/service/TemplateService.java
Outdated
Show resolved
Hide resolved
jminkkk
previously approved these changes
Aug 5, 2024
Comment on lines
52
to
59
| public void deleteById(Long id) { | ||
| if (templateRepository.existsByCategoryId(id)) { | ||
| throw new CodeZapException(HttpStatus.BAD_REQUEST, "템플릿이 존재하는 카테고리는 삭제할 수 없습니다."); | ||
| } | ||
| if (id == DEFAULT_CATEGORY) { | ||
| throw new CodeZapException(HttpStatus.BAD_REQUEST, "기본 카테고리는 삭제할 수 없습니다."); | ||
| } | ||
| categoryRepository.deleteById(id); |
There was a problem hiding this comment.
[넘어가도 됩니다] if 문을 따로 메서드로 빼도 좋을 것 같아요.
HoeSeong123
dismissed stale reviews from jminkkk, kyum-q, and zangsu
via
d125035
zangsu
approved these changes
Aug 6, 2024
jminkkk
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡️ 관련 이슈
close #191, #250, #251
📍주요 변경 사항
🎸기타