카테고리 생성 시 생성된 카테고리 값 반환 #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zangsu
previously approved these changes
Aug 19, 2024
Comment on lines
36
to
38
| ResponseEntity<CreateCategoryResponse> createCategory(MemberDto memberDto, | ||
| CreateCategoryRequest createCategoryRequest | ||
| ); |
There was a problem hiding this comment.
급한 내용이라면 무시해도 좋을 듯 합니다!
반환값이 void -> CreateCategoryResopnse 로 바뀐 부분도 문서화가 되어 있으면 좋을 것 같네요!
ApiResponse 부분에 아래 코드가 추가되면 어떨까요?
content = {@Content(schema = @Schema(implementation = CreateCategoryResponse.class))}There was a problem hiding this comment.
그런데 다시 다른 문서화들을 보니 해당 코드가 거의 다 없는 것 같기도 하고~~
그냥 나중에 한번에 추가하는 PR 이 생기는 게 더 편할 것 같기도 합니다 크크
There was a problem hiding this comment.
일부로 모든 성공 API에서 @Schema 제거 했습니다 ~
제거해도 반환하는 Schema로 자동 Swagger 설정이 됩니다 ~
HoeSeong123
reviewed
Aug 19, 2024
Comment on lines
36
to
38
| ResponseEntity<CreateCategoryResponse> createCategory(MemberDto memberDto, | ||
| CreateCategoryRequest createCategoryRequest | ||
| ); |
There was a problem hiding this comment.
이제까지 켬미의 리팩토링 스타일을 보면 아래와 같이 수정되어야 할 것 같은데 맞을까요?
Suggested change
| ResponseEntity<CreateCategoryResponse> createCategory(MemberDto memberDto, | |
| CreateCategoryRequest createCategoryRequest | |
| ); | |
| ResponseEntity<CreateCategoryResponse> createCategory( | |
| MemberDto memberDto, | |
| CreateCategoryRequest createCategoryRequest | |
| ); |
HoeSeong123
approved these changes
Aug 19, 2024
zangsu
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경 사항