Modal 컴포넌트 완성 #526
Merged
Modal 컴포넌트 완성 #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hain-tain
reviewed
Aug 21, 2024
| document.body, | ||
| ); | ||
| }; | ||
|
|
||
| const Header = ({ children, ...props }: PropsWithChildren<HTMLAttributes<HTMLDivElement>>) => ( | ||
| <S.Header {...props}>{children}</S.Header> | ||
| const Title = ({ children }: { children: ReactNode }) => ( |
21 tasks
Jaymyong66
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡️ 관련 이슈
#510
📍주요 변경 사항
1. 모달 컴포넌트의 요소(Header, Body, Footer) 간 'gap' 추가
2. Header를 TItle로 이름/기능 변경
3. Body가 모달의 전체 사이즈를 차지하도록 변경
4. Footer를 모달의 하단에 고정
5. Body만 스크롤 활성화