Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

기존 분기처리된 쿼리를 Specification를 사용하여 변경 #531

Merged
merged 6 commits into from
Aug 22, 2024

Conversation

jminkkk
Copy link
Contributor

@jminkkk jminkkk commented Aug 21, 2024

⚡️ 관련 이슈

close #495

📍주요 변경 사항

  1. 템플릿 목록 조회 시 비회원도 조회할 수 있도록 MemberDto 제거
  2. explore API 제거, 템플릿 목록 조회 API와 통일
  3. 기존 분기처리된 쿼리를 Specification를 사용하여 변경

🎸기타

  1. TemplateServiceTest에서 FakeTemplateRepository를 사용하는데 FakeTemplateRepository에서 Specification를 처리할 수 없어 서비스 테스트의 목록 조회 테스트를 주석해놓았습니다.
  • 실제 구현을 사용하여 처리하는 등 FakeRepository를 사용한 테스트 방식에 대해 논의해보아야 할 것 같아요

@jminkkk jminkkk added feature 기능 추가 BE 백엔드 labels Aug 21, 2024
@jminkkk jminkkk added this to the 4차 스프린트 🐔 milestone Aug 21, 2024
@jminkkk jminkkk self-assigned this Aug 21, 2024
zangsu
zangsu previously approved these changes Aug 22, 2024
Copy link
Contributor

@zangsu zangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨어요 몰리!!

@jminkkk jminkkk dismissed zangsu’s stale review August 22, 2024 09:02

The merge-base changed after approval.

Copy link
Contributor

@kyum-q kyum-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

몰리 PR 리뷰 몇개만 남길게요 ~!

@jminkkk jminkkk closed this Aug 22, 2024
@jminkkk jminkkk reopened this Aug 22, 2024
Copy link
Contributor

@HoeSeong123 HoeSeong123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.

Comment on lines +49 to +51
private void addKeywordPredicate(List<Predicate> predicates, CriteriaBuilder criteriaBuilder, Root<Template> root,
CriteriaQuery<?> query
) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private void addKeywordPredicate(List<Predicate> predicates, CriteriaBuilder criteriaBuilder, Root<Template> root,
CriteriaQuery<?> query
) {
private void addKeywordPredicate(
List<Predicate> predicates,
CriteriaBuilder criteriaBuilder,
Root<Template> root,
CriteriaQuery<?> query
) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#532 pr에서 반영하겠습니다!

@zeus6768 zeus6768 merged commit a6aed99 into dev/be Aug 22, 2024
8 checks passed
@zeus6768 zeus6768 deleted the feat/495-findAll branch August 22, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE 백엔드 feature 기능 추가
Projects
Status: Weekend Done
Development

Successfully merging this pull request may close these issues.

5 participants