TemplateTagServiceTest 추가 #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyum-q
reviewed
Sep 18, 2024
backend/src/test/java/codezap/tag/service/TemplateTagServiceTest.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/codezap/tag/service/TemplateTagServiceTest.java
Outdated
Show resolved
Hide resolved
zangsu
reviewed
Sep 19, 2024
backend/src/test/java/codezap/tag/service/TemplateTagServiceTest.java
Outdated
Show resolved
Hide resolved
HoeSeong123
requested changes
Sep 19, 2024
| } | ||
|
|
||
| @Test | ||
| @DisplayName("성공: 이미 있는 템플릿 태그가 포함된 경우 중복 저장하지 않고 새 태그만 생성") |
There was a problem hiding this comment.
Suggested change
| @DisplayName("성공: 이미 있는 템플릿 태그가 포함된 경우 중복 저장하지 않고 새 태그만 생성") | |
| @DisplayName("성공: 이미 있는 태그가 포함된 경우 중복 저장하지 않고 새 태그만 생성") |
| // given | ||
| Template template = createTemplate(); | ||
| Tag existTag = tagRepository.save(new Tag("tag1")); | ||
| TemplateTag existTemplateTag = new TemplateTag(template, existTag); |
There was a problem hiding this comment.
해당 코드는 없어도 될 것 같은데 만약 필요하다면 다음과 같이 수정해야 할 것 같네요
Suggested change
| TemplateTag existTemplateTag = new TemplateTag(template, existTag); | |
| TemplateTag existTemplateTag = templateTagRepository.save(new TemplateTag(template, existTag)); |
There was a problem hiding this comment.
와우 꼼꼼쓰 정꼼꼼으로 개명 어때요?
| ); | ||
| } | ||
|
|
||
| private List<String> getSavedTagNames(Template template) { |
There was a problem hiding this comment.
getSavedTagNames라고 해서 저장된 모든 태그 목록이 나오는 줄 알았는데 템플릿 태그가 나오는 거였군요
getSavedTemplateTagNames로 조금 더 명확하게 네이밍해보는 건 어떤가요?
Suggested change
| private List<String> getSavedTagNames(Template template) { | |
| private List<String> getSavedTemplateTagNames(Template template) { |
| // then | ||
| List<String> afterTemplateTags = getSavedTagNames(template); | ||
| assertAll( | ||
| () -> assertThat(beforeTemplateTags).doesNotContain(existTag.getName()), |
There was a problem hiding this comment.
저장 전에는 tag2, tag3도 포함되어 있지 않다는 것도 추가되면 좋을 것 같아요!!
Suggested change
| () -> assertThat(beforeTemplateTags).doesNotContain(existTag.getName()), | |
| () -> assertThat(beforeTemplateTags).doesNotContainAnyElementsOf(tagNames), |
|
|
||
|
|
||
| @Transactional | ||
| class TemplateTagServiceTest extends ServiceTest { |
There was a problem hiding this comment.
전체적으로 빈 리스트가 온 경우에 대한 테스트도 있으면 좋을 것 같아요!!
There was a problem hiding this comment.
GetByTemplate에는 작성이 되어있어
FindAllByTemplates 에 빈 목록 추가해두었고 조회는 아니지만 UpdateTags에 전체 태그를 삭제했을 경우 빈 목록 테스트 추가했습니답!
추가 테스트가 더 필요할 부분 있다면 편하게 말씀 부탁드려용
| templateTagService.deleteByIds(List.of(template.getId())); | ||
|
|
||
| // then | ||
| assertThat(templateTagRepository.findAllByTemplate(template)).isEmpty(); |
There was a problem hiding this comment.
템플릿태그에서는 삭제됐지만 태그에서는 살아있다는 것도 보여주면 좋을 것 같네요
zeus6768
reviewed
Sep 19, 2024
backend/src/test/java/codezap/tag/service/TemplateTagServiceTest.java
Outdated
Show resolved
Hide resolved
zeus6768
approved these changes
Sep 20, 2024
HoeSeong123
approved these changes
Sep 20, 2024
zangsu
approved these changes
Sep 20, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡️ 관련 이슈
close #645
📍주요 변경 사항
🎸기타
[REFACTOR] Service Layer 리팩토링 #650 (comment)