검색 쿼리 개선 #703
Merged
검색 쿼리 개선 #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…에 조회 후 애플리케이션 단에서 template으로 template tag 재조회
… 후 애플리케이션 단에서 template으로 thumbnail 재조회
kyum-q
approved these changes
Sep 27, 2024
Comment on lines
+55
to
+59
| public List<Tag> findAllByTemplateId(Long templateId) { | ||
| return templateTagRepository.findAllByTemplateId(templateId).stream() | ||
| .map(TemplateTag::getTag) | ||
| .toList(); | ||
| } |
There was a problem hiding this comment.
나중에 Tag 를 받도록 변경하면 좋을 것 같아욧 ~
Comment on lines
+42
to
+43
| root.fetch("category", JoinType.LEFT); | ||
| root.fetch("member", JoinType.LEFT); |
Comment on lines
+30
to
+31
| List<Long> templateIds = templates.stream() | ||
| .map(Template::getId) |
There was a problem hiding this comment.
추후 id만 받도록 코드 개선하면 커버링 인덱스를 이용할 수 있을 것 같아요 ~
zangsu
approved these changes
Sep 27, 2024
| } | ||
|
|
||
| public List<TemplateTag> getAllTemplateTagsByTemplates(List<Template> templates) { | ||
| List<Long> templateIds = templates.stream().map(Template::getId).toList(); |
There was a problem hiding this comment.
Suggested change
| List<Long> templateIds = templates.stream().map(Template::getId).toList(); | |
| List<Long> templateIds = templates.stream() | |
| .map(Template::getId) | |
| .toList(); |
zeus6768
approved these changes
Sep 27, 2024
| @@ -14,6 +14,8 @@ public interface ThumbnailRepository { | |||
|
|
|||
| List<Thumbnail> findAll(); | |||
|
|
|||
| List<Thumbnail> findAllByTemplateIn(List<Long> templateIds); | |||
There was a problem hiding this comment.
Suggested change
| List<Thumbnail> findAllByTemplateIn(List<Long> templateIds); | |
| List<Thumbnail> findAllByTemplateIdsIn(List<Long> templateIds); |
| return new FindAllTemplatesResponse( | ||
| page.getTotalPages(), | ||
| page.getTotalElements(), | ||
| findAllTemplateByResponse); | ||
| } | ||
|
|
||
| private List<FindAllTemplateItemResponse> getFindAllTemplateItemResponses(List<Template> templates, LikedChecker likedChecker) { |
There was a problem hiding this comment.
Suggested change
| private List<FindAllTemplateItemResponse> getFindAllTemplateItemResponses(List<Template> templates, LikedChecker likedChecker) { | |
| private List<FindAllTemplateItemResponse> findAllTemplateItemResponses(List<Template> templates, LikedChecker likedChecker) { |
HoeSeong123
reviewed
Sep 27, 2024
| @@ -52,6 +52,17 @@ public List<Tag> findAllByTemplate(Template template) { | |||
| .toList(); | |||
| } | |||
|
|
|||
| public List<Tag> findAllByTemplateId(Long templateId) { | |||
HoeSeong123
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡️ 관련 이슈
close #673
📍주요 변경 사항