템플릿 단건 조회/ 템플릿 삭제/ 태그 조회 성능 개선 #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…://github.com/woowacourse-teams/2024-code-zap into refactor/673-performance-template-find-delete
kyum-q
requested review from
HoeSeong123,
jminkkk,
zeus6768 and
zangsu
and removed request for
HoeSeong123 and
jminkkk
zeus6768
reviewed
Sep 26, 2024
backend/src/main/java/codezap/tag/repository/TemplateTagJpaRepository.java
Outdated
Show resolved
Hide resolved
Comment on lines
27
to
33
| @Query(""" | ||
| SELECT t.id | ||
| FROM Template t | ||
| WHERE t.member.id = :memberId | ||
| """) | ||
| List<Long> findAllIdsByMemberId(Long memberId); | ||
|
|
There was a problem hiding this comment.
이 메서드 사용되는 곳이 없는 것 같은걸요~!!
backend/src/main/java/codezap/template/repository/TemplateRepository.java
Outdated
Show resolved
Hide resolved
HoeSeong123
reviewed
Sep 26, 2024
| @@ -29,6 +30,6 @@ public class Likes extends BaseTimeEntity { | |||
| @ManyToOne(optional = false) | |||
There was a problem hiding this comment.
단순 궁금증인데 전체적으로 지연 로딩을 적용하기로 했다고 했었는데 그거는 나중에 전체적으로 한번에 반영하는건가요??
아니면 담당한 사람이 확인??
There was a problem hiding this comment.
헉스... 다음 스프린트에 반드시 적용해야겠습니다
Comment on lines
48
to
49
| return templateTagRepository.findAllTagsByTemplate(template) | ||
| .stream() |
There was a problem hiding this comment.
Suggested change
| return templateTagRepository.findAllTagsByTemplate(template) | |
| .stream() | |
| return templateTagRepository.findAllTagsByTemplate(template); |
zangsu
previously approved these changes
Sep 26, 2024
backend/src/main/java/codezap/tag/repository/TemplateTagJpaRepository.java
Show resolved
Hide resolved
zeus6768
previously approved these changes
Sep 27, 2024
| @@ -29,6 +30,6 @@ public class Likes extends BaseTimeEntity { | |||
| @ManyToOne(optional = false) | |||
There was a problem hiding this comment.
헉스... 다음 스프린트에 반드시 적용해야겠습니다
jminkkk
previously approved these changes
Sep 27, 2024
zeus6768
previously approved these changes
Sep 27, 2024
HoeSeong123
previously approved these changes
Sep 27, 2024
kyum-q
dismissed stale reviews from HoeSeong123, zeus6768, and jminkkk
via
379e913
jminkkk
previously approved these changes
Sep 27, 2024
zangsu
approved these changes
Sep 27, 2024
zeus6768
approved these changes
Sep 27, 2024
HoeSeong123
approved these changes
Sep 27, 2024
jminkkk
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡️ 관련 이슈
close #673
📍주요 변경 사항
🎸기타