템플릿 생성, 수정 쿼리 성능 개선 #715
Merged
템플릿 생성, 수정 쿼리 성능 개선 #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jminkkk
previously approved these changes
Sep 27, 2024
| @@ -13,6 +13,8 @@ public interface TagRepository { | |||
|
|
|||
| Optional<Tag> findByName(String name); | |||
|
|
|||
| List<Tag> findByNameIn(List<String> names); | |||
zeus6768
previously approved these changes
Sep 27, 2024
Comment on lines
18
to
20
| List<String> findNameByNamesIn(List<String> names); | ||
|
|
||
| Tag save(Tag tag); |
There was a problem hiding this comment.
테스트코드에서만 사용되는 메서드입니다~!
Suggested change
| List<String> findNameByNamesIn(List<String> names); | |
| Tag save(Tag tag); |
kyum-q
previously approved these changes
Sep 27, 2024
| .map(tag -> new TemplateTag(template, tag)) | ||
| .toList() | ||
| ); | ||
| List<Tag> existingTags = new ArrayList<>(tagRepository.findByNameIn(tagNames)); |
There was a problem hiding this comment.
방어적 복사를 하신건가요? 이유가 궁금 ~
나중에 얘기해봐요 왜냐면 전 다 안했거든요 ~
There was a problem hiding this comment.
existingTags 에 새로운 원소를 추가하는 로직이 존재해요.
findByNameIn 의 return 값이 UnmodifiableList 라서 수정 가능한 리스트로 변경해 주는 로직입니다!
Comment on lines
+29
to
+32
| List<Tag> existingTags = new ArrayList<>(tagRepository.findByNameIn(tagNames)); | ||
| List<String> existNames = existingTags.stream() | ||
| .map(Tag::getName) | ||
| .toList(); |
There was a problem hiding this comment.
나중에 repository로 부터 name만 받도록 수정해서 커버링 인덱스를 사용해봐요 ~
jminkkk
previously approved these changes
Sep 27, 2024
zeus6768
previously approved these changes
Sep 27, 2024
zangsu
dismissed stale reviews from HoeSeong123, jminkkk, zeus6768, and kyum-q
via
8280a69
zeus6768
approved these changes
Sep 27, 2024
HoeSeong123
approved these changes
Sep 27, 2024
kyum-q
approved these changes
Sep 27, 2024
jminkkk
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡️ 관련 이슈
close #673
📍주요 변경 사항