-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
카테고리, 태그, 템플릿 목록 로딩 처리 개선 #784
Open
Hain-tain
wants to merge
11
commits into
dev/fe
Choose a base branch
from
refactor/695-apply-skeleton
base: dev/fe
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+637
−282
Open
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8079f8b
refactor(components): ScrollTopButton 컴포넌트 분리
Hain-tain 6890fd6
refactor(MyTemplatePage): 컴포넌트 분리 및 태그목록, 카테고리 목록 서스펜스 적용
Hain-tain 07f77e3
refactor(components): TemplateDeleteSelection, TemplateListSectionLoa…
Hain-tain 7c02ab2
refactor(src): useKeyword, useShowTemplateList, useSelectAndDeleteTem…
Hain-tain 1f7e8a2
refactor(templates): 사용하지 않는 useTemplateCategoryTagQueries 훅 삭제
Hain-tain 00c231b
refactor(pages): useShowTemplateList => useFilteredTemplateList로 이름 변경
Hain-tain 5cd9160
refactor(src): useKeyword => useSearchKeyword로 이름 변경
Hain-tain 8e8086d
refactor(ConfirmDeleteModal): ConfirmDeleteModalProps =>Props 로 변경
Hain-tain ce63a7a
refactor(CategoryListSection): Flex 대신 스타일드 컴포넌트로 스타일 지정
Hain-tain 21ca869
refactor(ConfirmDeleteModal): Modal 합성 컴포넌트의 하위 컴포넌트 사용하도록 변경
Hain-tain e0adebf
refactor(queries): useSuspenseQuery를 사용하는 훅들 수동으로 error 전파
Hain-tain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
export { useSourceCode } from './useSourceCode'; | ||
export { useTag } from './useTag'; | ||
export { useKeyword } from './useKeyword'; | ||
export { useSearchKeyword } from './useSearchKeyword'; |
4 changes: 2 additions & 2 deletions
4
frontend/src/hooks/template/useKeyword.ts → ...nd/src/hooks/template/useSearchKeyword.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
...end/src/pages/MyTemplatesPage/components/CategoryListSection/CategoryListSection.style.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
import styled from '@emotion/styled'; | ||
|
||
export const CategoryListSectionContainer = styled.div` | ||
display: flex; | ||
flex-direction: column; | ||
gap: 2.5rem; | ||
margin-top: 4.5rem; | ||
`; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 15 additions & 17 deletions
32
frontend/src/pages/MyTemplatesPage/components/ConfirmDeleteModal/ConfirmDeleteModal.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
export { useShowTemplateList } from './useShowTemplateList'; | ||
export { useFilteredTemplateList } from './useFilteredTemplateList'; | ||
export { useSelectAndDeleteTemplateList } from './useSelectAndDeleteTemplateList'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굿!