[BE] 닉네임 검증 정규표현식 삭제 및 앞 뒤 공백 제거 로직 추가 #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reddevilmidzy
requested changes
Jul 29, 2024
| } | ||
|
|
||
| private void validate(final String value) { | ||
| if (StringUtils.isBlank(value)) { | ||
| throw new InvalidNameFormatException("페어의 이름이 비어있습니다."); | ||
| } | ||
| if (value.length() > MAX_LENGTH) { | ||
| throw new InvalidNameFormatException("이름은 10자 이하여야 합니다."); | ||
| throw new InvalidNameFormatException(String.format("이름은 %d자 이하여야 합니다.", MAX_LENGTH)); |
There was a problem hiding this comment.
공백을 제거한다음 10자인걸 확인해줘야 할거 같아요!
| @@ -13,7 +13,7 @@ | |||
| class PairNameTest { | |||
|
|
|||
| @ParameterizedTest | |||
| @ValueSource(strings = {"레디!", "파슬리 🌿", "ㄹ ㅔ ㅁ ㄴ ㅔ", "lemone"}) | |||
| @ValueSource(strings = {"레디!", "파슬리 🌿", "여 왕 님", "lemon", "abcdeabcde"}) | |||
reddevilmidzy
approved these changes
Jul 29, 2024
Comment on lines
+50
to
+53
| @Test | ||
| @DisplayName("공백이 제거 된 후 10 글자 이하 닉네임은 허용한다.") | ||
| void allow_10_characters_with_trim_name_length() { | ||
| // given |
yechop
requested changes
Jul 29, 2024
| @@ -13,7 +13,7 @@ | |||
| class PairNameTest { | |||
|
|
|||
| @ParameterizedTest | |||
| @ValueSource(strings = {"레디!", "파슬리 🌿", "ㄹ ㅔ ㅁ ㄴ ㅔ", "lemone"}) | |||
| @ValueSource(strings = {"레디!", "파슬리 🌿", "여 왕 님", "lemon", "abcdeabcde"}) | |||
| @DisplayName("한글, 한글 자음 & 모음, 영어, 기호, 이모지가 들어간 이름을 생성한다.") | |||
| void create_name_contains_special_character(String validName) { | |||
There was a problem hiding this comment.
Suggested change
| void create_name_contains_special_character(String validName) { | |
| void create_name_contains_special_character(final String validName) { |
There was a problem hiding this comment.
해당 누락 Final 같이 다음 이슈에서 수정 PR하겠습니다.😊`
yechop
approved these changes
Jul 29, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
연관된 이슈
구현한 기능
상세 설명
닉네임은 중간 공백은 허용한다는 정책 및 러프하게 이모지, 영어, 숫자는 허용하기 위한 코드 수정입니다.