Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] 코드 리뷰 알림 기능 보완 #190

Merged
merged 3 commits into from
Jul 31, 2024
Merged

[BE] 코드 리뷰 알림 기능 보완 #190

merged 3 commits into from
Jul 31, 2024

Conversation

koust6u
Copy link
Member

@koust6u koust6u commented Jul 31, 2024

연관된 이슈

구현한 기능

  • 별도 서버 사용 없이 슬랙 메세지 자동 보내기 기능 구현
  • 민감 정보 Secret으로 추출

상세 설명

reddevilmidzy
reddevilmidzy approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@reddevilmidzy reddevilmidzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

쉿

@koust6u koust6u changed the title [BE] 코드 리뷰 알림 기능 민감 정보 은닉화 [BE] 코드 리뷰 알림 기능 보완 Jul 31, 2024
kelly6bf
kelly6bf approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@kelly6bf kelly6bf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😋

@koust6u koust6u merged commit 7e10d69 into BE/dev Jul 31, 2024
1 check passed
@koust6u koust6u deleted the BE/feature/#188 branch July 31, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiHyeonL JiHyeonL JiHyeonL approved these changes

@reddevilmidzy reddevilmidzy reddevilmidzy approved these changes

@kelly6bf kelly6bf kelly6bf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@koust6u @JiHyeonL @reddevilmidzy @kelly6bf