refactor: 상수 사용 및 타입 변경

woowacourse-teams · Aug 7, 2024 · 722e2c4 · 722e2c4
1 parent 10ddabf
commit 722e2c4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/frontend/src/hooks/useDashboardCreateForm/index.tsx b/frontend/src/hooks/useDashboardCreateForm/index.tsx
@@ -74,7 +74,7 @@ export default function useDashboardCreateForm(): UseDashboardCreateFormReturn {
   const setQuestionOptions = (index: number) => (options: Option[]) => {
     setApplyState((prevState) => {
       const questionsCopy = [...prevState];
-      questionsCopy[index].choices = options.map(({ value }, i) => ({ choice: value, order_index: i }));
+      questionsCopy[index].choices = options.map(({ value }, i) => ({ choice: value, orderIndex: i }));
       return questionsCopy;
     });
   };
@@ -89,7 +89,7 @@ export default function useDashboardCreateForm(): UseDashboardCreateFormReturn {
 
   const setQuestionPrev = (index: number) => () => {
     setApplyState((prevState) => {
-      if (index > 3) {
+      if (index > initialApplyState.length) {
         const questionsCopy = [...prevState];
         const temp = questionsCopy[index];
         questionsCopy[index] = questionsCopy[index - 1];
@@ -102,7 +102,7 @@ export default function useDashboardCreateForm(): UseDashboardCreateFormReturn {
 
   const setQuestionNext = (index: number) => () => {
     setApplyState((prevState) => {
-      if (index >= 3 && index < prevState.length - 1) {
+      if (index >= initialApplyState.length && index < prevState.length - 1) {
         const questionsCopy = [...prevState];
         const temp = questionsCopy[index];
         questionsCopy[index] = questionsCopy[index + 1];
@@ -114,7 +114,7 @@ export default function useDashboardCreateForm(): UseDashboardCreateFormReturn {
   };
 
   const deleteQuestion = (index: number) => {
-    if (index < 3) return;
+    if (index < initialApplyState.length) return;
     setApplyState((prevState) => prevState.filter((_, i) => i !== index));
   };
 

diff --git a/frontend/src/types/dashboard.ts b/frontend/src/types/dashboard.ts
@@ -3,7 +3,7 @@ export interface Question {
   question: string;
   choices: {
     choice: string;
-    order_index: number;
+    orderIndex: number;
   }[];
   required: boolean;
 }
@@ -21,5 +21,5 @@ export type StepState = 'recruitmentForm' | 'applyForm' | 'finished';
 
 export interface QuestionOption {
   choice: string;
-  order_index: number;
+  orderIndex: number;
 }