feat-fe: Switch Toggle 컴포넌트 구현 #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
1722479678.553879 |
llqqssttyy
requested changes
Aug 1, 2024
|
|
||
| const Switch = styled.div<StyleProps>` | ||
| width: 5rem; | ||
| --parent-width: 5rem; |
There was a problem hiding this comment.
사소한 건데 변수는 잘 보이게 최상단으로 끌어 올려주는 거 어떨까요? 가독성에 대한 거라서 필수는 아닙니다.
llqqssttyy
approved these changes
Aug 1, 2024
seongjinme
approved these changes
Aug 1, 2024
Comment on lines
+45
to
+47
| transform: ${({ isChecked }) => | ||
| isChecked ? 'translate(calc(var(--parent-width) - var(--parent-padding)*2 - 100%))' : 'translate(0)'}; | ||
| transition: transform 0.2s; |
seongjinme
pushed a commit
that referenced
this pull request
Aug 23, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jeongwoo Park <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue description
목적
작업 세부사항
참고 사항
COM_TOGGLE
closes #229