feat-fe: 공통 컴포넌트 SideBar 구현 #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1722864361.664549 |
llqqssttyy
approved these changes
Aug 6, 2024
| {options.map(({ text, isSelected }, index) => ( | ||
| // eslint-disable-next-line react/no-array-index-key | ||
| <Accordion.ListItem key={index}> | ||
| <S.ContentButton isSelected={isSelected}>{text}</S.ContentButton> |
There was a problem hiding this comment.
이 버튼들을 눌러서 페이지를 이동해야 하니 NavigateButton 정도의 이름도 괜찮을 것 같아요.
seongjinme
reviewed
Aug 6, 2024
Comment on lines
+13
to
+18
| // TODO: 현재 아코디언의 오픈값을 True로 설정합니다. 추후에 아코디언이 추가될 경우 변경이 필요합니다. | ||
| const [isOpen] = useState(true); | ||
|
|
||
| const toggleAccordion = () => { | ||
| // setIsOpen(!isOpen); | ||
| }; |
There was a problem hiding this comment.
요 부분은 추후에 수정 필요한 부분으로 이해하고 넘어갈게요!
Comment on lines
+20
to
+22
| <Accordion.ListItem key={index}> | ||
| <S.NavButton isSelected={isSelected}>{text}</S.NavButton> | ||
| </Accordion.ListItem> |
There was a problem hiding this comment.
Accordion.ListItem 컴포넌트 요소를 따로 빼고, 그 안에 button 요소를 넣으셨네요. 이런 경우에 해당 리스트(<li>) 항목에 대한 bullet point 표식은 Accordion.ListItem 보다는 button 요소에 삽입했다면 어땠을까 싶습니다. 현재는 isSelected prop에 의한 스타일 변경 사항이 button 요소에만 적용되고 bullet point에는 적용되지 않아서, 실제 Storybook으로 체크해보면 조금 어색하게 느껴지거든요.
Accordion.ListItem에 삽입되어 있는 아래의 스타일 코드를 S.NavButton으로 대신 적용하는 아이디어를 한 번 검토해주시면 좋겠습니다.
padding: 0.4rem 0rem;
&::before {
content: '•';
width: 1rem;
aspect-ratio: 1/1;
margin-right: 0.8rem;
}
seongjinme
approved these changes
Aug 6, 2024
lurgi
added a commit
that referenced
this pull request
Aug 7, 2024
seongjinme
pushed a commit
that referenced
this pull request
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
참고 사항
관련 이슈