feat-fe: 공고 페이지에서 사용할 useDashboardCreateForm훅 구현 #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
lurgi
changed the title
Co-authored-by: Seongjin Hong <[email protected]> feat: useDashboardCreateForm 훅 구현
|
1723006964.604829 |
|
코드가 더럽지만 일단.... ㅠㅜ |
seongjinme
requested changes
Aug 7, 2024
There was a problem hiding this comment.
API 스펙과 일치하도록 타입을 잘 정의해 주신 것 같습니다 👍
frontend/src/types/dashboard.ts
Outdated
| question: string; | ||
| choices: { | ||
| choice: string; | ||
| order_index: number; |
There was a problem hiding this comment.
해당 API 스펙 문서에서 key값이 모두 camelCase로 변경되었어요. 이 부분도 반영해 주시면 감사하겠습니다!
Suggested change
| order_index: number; | |
| orderIndex: number; |
frontend/src/types/dashboard.ts
Outdated
|
|
||
| export interface QuestionOption { | ||
| choice: string; | ||
| order_index: number; |
There was a problem hiding this comment.
요 부분도 마찬가지입니다 :)
Suggested change
| order_index: number; | |
| orderIndex: number; |
|
|
||
| const setQuestionPrev = (index: number) => () => { | ||
| setApplyState((prevState) => { | ||
| if (index > 3) { |
There was a problem hiding this comment.
요 매직 넘버(3)는 훅 코드 상위나 다른 곳에 상수 처리하면 어떨까 제안드려 봅니다 🙏
llqqssttyy
requested changes
Aug 7, 2024
llqqssttyy
approved these changes
Aug 7, 2024
seongjinme
approved these changes
Aug 7, 2024
seongjinme
pushed a commit
that referenced
this pull request
Aug 23, 2024
Co-authored-by: Jeongwoo Park <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue description
목적
작업 세부사항
참고 사항
RECRUIT_ROUTE
closes #277