fix-fe: msw, sentry 충돌 해결 #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
1723470911.448789 |
|
1723470956.188389 |
seongjinme
approved these changes
Aug 13, 2024
seongjinme
pushed a commit
that referenced
this pull request
Aug 23, 2024
Co-authored-by: Jeongwoo Park <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue description
목적
작업 세부사항
참고 사항
FIX_SENTRY_MSW
closes #403
별건 아니구요, url머시기 에러 나타나는게, sentry를 실행하고, msw로 모킹을 시도하면서 충돌이 나는 거였습니다. sentry.init()시 request가 가는 것 같은데, 그것 때문인가봐요.
msw를 먼저 실행하고, sentry.init을 하는 걸로 해결하였습니다.