feat-fe: Date Picker 이벤트 발생 컴포넌트 변경 #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
1723612961.027869 |
llqqssttyy
approved these changes
Aug 14, 2024
| <S.Container> | ||
| <S.Container onClick={handleIconClick}> |
seongjinme
reviewed
Aug 14, 2024
| @@ -18,7 +18,7 @@ export default function DateInput({ label, innerText, ...props }: DateInputProps | |||
| }; | |||
|
|
|||
| return ( | |||
| <S.Container> | |||
| <S.Container onClick={handleIconClick}> | |||
There was a problem hiding this comment.
오 이벤트 버블링을 사용하셨군요! 멋집니다 👍
Comment on lines
33
to
35
| outline={false} | ||
| size="sm" | ||
| color="white" |
There was a problem hiding this comment.
button 요소의 type를 button으로 지정해주면 의도치 않은 이벤트 발생으로부터 조금 더 안전하지 않을까 싶습니다.
Suggested change
| outline={false} | |
| size="sm" | |
| color="white" | |
| outline={false} | |
| size="sm" | |
| color="white" | |
| type="button" |
seongjinme
approved these changes
Aug 14, 2024
| @@ -7,7 +7,7 @@ export default function IconButton({ | |||
| size = 'sm', | |||
| outline = true, | |||
| shape = 'round', | |||
| type, | |||
| type = 'button', | |||
seongjinme
pushed a commit
that referenced
this pull request
Aug 23, 2024
Co-authored-by: Jeongwoo Park <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue description
목적
작업 세부사항
참고 사항
CHANGE_DATE_EVENT_TRIGGER
closes #441