-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix-fe: 전화번호 포맷팅 버그 #585
Merged
Merged
fix-fe: 전화번호 포맷팅 버그 #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llqqssttyy
requested review from
seongjinme and
lurgi
and removed request for
seongjinme
August 21, 2024 09:10
1724231480.051069 |
1724231481.544289 |
1724231483.538859 |
1724231608.814039 |
seongjinme
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
현재는 11자리 숫자 여부로만 체크하고 있지만, 서버에서는 좀 더 디테일한 조건으로 검증하고 있는 것 같아요. 검증 조건을 함께 일치시킬지, 아니면 서버에서 돌아오는 에러 메시지를 보여주는 선으로 정리할지 정하면 좋을 것 같습니다. 수고하셨어요!
lurgi
approved these changes
Aug 21, 2024
seongjinme
pushed a commit
that referenced
this pull request
Aug 23, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kim Da Eun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue description
목적
COM_FOR_01
closes #584