Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-fe: 전화번호 포맷팅 버그 #585

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Conversation

github-actions[bot]
Copy link
Contributor

Original issue description

목적

전화번호 포맷팅 버그

아래의 별표줄 밑에 요구사항 ID만 작성해주세요. Prefix 금지!


COM_FOR_01

closes #584

@github-actions github-actions bot added fix 버그 수정 frontend 프론트엔드 labels Aug 21, 2024
@github-actions github-actions bot added this to the 스프린트 3.0 milestone Aug 21, 2024
Copy link
Contributor Author

1724231480.051069

Copy link
Contributor Author

1724231481.544289

Copy link
Contributor Author

1724231483.538859

Copy link
Contributor Author

1724231608.814039

Copy link
Contributor

@seongjinme seongjinme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

현재는 11자리 숫자 여부로만 체크하고 있지만, 서버에서는 좀 더 디테일한 조건으로 검증하고 있는 것 같아요. 검증 조건을 함께 일치시킬지, 아니면 서버에서 돌아오는 에러 메시지를 보여주는 선으로 정리할지 정하면 좋을 것 같습니다. 수고하셨어요!

@llqqssttyy llqqssttyy merged commit 7ef48ba into fe/develop Aug 21, 2024
18 checks passed
@llqqssttyy llqqssttyy deleted the fe-584-COM_FOR_01 branch August 21, 2024 10:35
seongjinme pushed a commit that referenced this pull request Aug 23, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kim Da Eun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 버그 수정 frontend 프론트엔드
Projects
Status: 완료
Development

Successfully merging this pull request may close these issues.

3 participants