Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat-fe: 랜딩 페이지 구현 #658

Merged
merged 21 commits into from
Sep 13, 2024
Merged

feat-fe: 랜딩 페이지 구현 #658

merged 21 commits into from
Sep 13, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 11, 2024

목적

랜딩 페이지를 구현합니다.

구현 목록

  • 디자인 시안에 따라 랜딩 페이지를 구현
  • 가장 하단에 크루루 새로 시작하기 버튼 추가
  • scroll to top 버튼 추가

참고사항

  • 피그마에서 이미지를 1배수로 뽑으면 해상도가 너무 낮아 3배수로 뽑고 webp로 변환하여 넣었습니다.
  • icon8 리소스(남자 3d 일러스트)는 무료 버전에서 해상도를 조절할 수 없어 화질이 떨어지는 느낌을 받으실 수 있습니다.
  • 파일 구조 리팩토링 중이라 섹션들을 컴포넌트로 분리하진 않았는데 코드 양이 너무 많다고 느껴지신다면 분리 작업 진행하겠습니다. 의견 주세요!
  • IconButton에서 다른 props를 받을 수 있도록 코드를 수정했습니다.

아래의 별표줄 밑에 요구사항 ID만 작성해주세요. Prefix 금지!


LAND_01

closes #657

@github-actions github-actions bot added feature 새로운 기능 frontend 프론트엔드 labels Sep 11, 2024
@github-actions github-actions bot added this to the 스프린트 4.0 milestone Sep 11, 2024
Copy link
Contributor Author

1726194771.226839

Copy link
Contributor Author

1726194775.397489

Copy link
Contributor Author

1726198771.026669

Copy link
Contributor

@seongjinme seongjinme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

렛서 감사합니다. 대강대강 만든 시안을 이렇게 멋지게 구현해 주셨네요 🙏

Copy link
Contributor

@lurgi lurgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

렛서 페이지 만드느라 너무 고생많으셨습니다!
스타일적인 피드백 뿐이라 반영할지는 렛서가 선택해주셨으면 합니다! 일단 어푸르브~
고생했어요~💙

Comment on lines +140 to +143

background: linear-gradient(155deg, rgba(243, 217, 238, 1) 0%, rgba(255, 255, 255, 0) 100%),
linear-gradient(0deg, rgba(255, 255, 255, 1) 0%, rgba(255, 255, 255, 0) 100%);
`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

경계선이 생기는데 그냥 to Bottom으로 만들어도 괜찮을 것 같은데용!

Copy link
Contributor

@llqqssttyy llqqssttyy Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to Bottom으로 만들어도 괜찮다는 말을 이해하지 못했어요!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
background: linear-gradient(155deg, rgba(243, 217, 238, 1) 0%, rgba(255, 255, 255, 0) 100%),
linear-gradient(0deg, rgba(255, 255, 255, 1) 0%, rgba(255, 255, 255, 0) 100%);
`;
background: linear-gradient(to bottom, rgba(243, 217, 238, 1) 0%,
rgba(243, 217, 238, 0.7) 70%,
rgba(255, 255, 255, 0) 100%);
`;

이 형태를 말한거였어요~ 위 코드는 예시코드입니당 (안돌려봄)

Copy link
Contributor

@llqqssttyy llqqssttyy Sep 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Values
The values to top, to bottom, to left, and to right are equivalent to the angles 0deg, 180deg, 270deg, and 90deg, respectively. The other values are translated into an angle.

to bottom이라는 값이 있군요.🫢 몰랐습니다.
시안대로 구현하려면 to right bottom으로 하면 되겠네요.
이 부분은 리팩토링 PR 생성하면 반영하도록 할게요~

Comment on lines 121 to 127
& > svg {
display: block;
font-size: 4rem;
color: ${({ theme }) => theme.baseColors.purplescale[500]};

animation: ${bounce} 2s infinite;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

개인적으로 chevron이 살짝 높게 떠있는 느낌이 드는데 조금 아래로 내리는 건 어떤가용?!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 동감합니다~ 낮출게요.

Comment on lines 185 to 191
<Button
size="fillContainer"
onClick={() => navigate(routes.signUp())}
color="primary"
>
크루루 새로 시작하기
</Button>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

크루루 새로 시작하기 폰트가 조금 작아보여요. 어떻게 생각하세욥?!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아무래도 너비가 길어져서 더 작아보이나봐요. 버튼 높이도 조금 작은 감이 있어서 함께 키우겠습니다~

image

@llqqssttyy llqqssttyy merged commit b206aee into fe/develop Sep 13, 2024
1 check passed
@llqqssttyy llqqssttyy deleted the fe-657-LAND_01 branch September 13, 2024 12:48
llqqssttyy added a commit that referenced this pull request Sep 19, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kim Da Eun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 새로운 기능 frontend 프론트엔드
Projects
Status: 완료
Development

Successfully merging this pull request may close these issues.

3 participants