-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat-fe: 랜딩 페이지 구현 #658
feat-fe: 랜딩 페이지 구현 #658
Conversation
1726194771.226839 |
1726194775.397489 |
1726198771.026669 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
렛서 감사합니다. 대강대강 만든 시안을 이렇게 멋지게 구현해 주셨네요 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
렛서 페이지 만드느라 너무 고생많으셨습니다!
스타일적인 피드백 뿐이라 반영할지는 렛서가 선택해주셨으면 합니다! 일단 어푸르브~
고생했어요~💙
|
||
background: linear-gradient(155deg, rgba(243, 217, 238, 1) 0%, rgba(255, 255, 255, 0) 100%), | ||
linear-gradient(0deg, rgba(255, 255, 255, 1) 0%, rgba(255, 255, 255, 0) 100%); | ||
`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
경계선이 생기는데 그냥 to Bottom으로 만들어도 괜찮을 것 같은데용!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to Bottom으로 만들어도 괜찮다는 말을 이해하지 못했어요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
background: linear-gradient(155deg, rgba(243, 217, 238, 1) 0%, rgba(255, 255, 255, 0) 100%), | |
linear-gradient(0deg, rgba(255, 255, 255, 1) 0%, rgba(255, 255, 255, 0) 100%); | |
`; | |
background: linear-gradient(to bottom, rgba(243, 217, 238, 1) 0%, | |
rgba(243, 217, 238, 0.7) 70%, | |
rgba(255, 255, 255, 0) 100%); | |
`; |
이 형태를 말한거였어요~ 위 코드는 예시코드입니당 (안돌려봄)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Values
The values to top, to bottom, to left, and to right are equivalent to the angles 0deg, 180deg, 270deg, and 90deg, respectively. The other values are translated into an angle.
to bottom이라는 값이 있군요.🫢 몰랐습니다.
시안대로 구현하려면 to right bottom으로 하면 되겠네요.
이 부분은 리팩토링 PR 생성하면 반영하도록 할게요~
frontend/src/pages/Landing/style.ts
Outdated
& > svg { | ||
display: block; | ||
font-size: 4rem; | ||
color: ${({ theme }) => theme.baseColors.purplescale[500]}; | ||
|
||
animation: ${bounce} 2s infinite; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
개인적으로 chevron이 살짝 높게 떠있는 느낌이 드는데 조금 아래로 내리는 건 어떤가용?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저도 동감합니다~ 낮출게요.
frontend/src/pages/Landing/index.tsx
Outdated
<Button | ||
size="fillContainer" | ||
onClick={() => navigate(routes.signUp())} | ||
color="primary" | ||
> | ||
크루루 새로 시작하기 | ||
</Button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
크루루 새로 시작하기 폰트가 조금 작아보여요. 어떻게 생각하세욥?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kim Da Eun <[email protected]>
목적
구현 목록
참고사항
LAND_01
closes #657