Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor-fe: 아토믹 디자인 패턴 도입 #660

Merged
merged 7 commits into from
Sep 13, 2024
Merged

refactor-fe: 아토믹 디자인 패턴 도입 #660

merged 7 commits into from
Sep 13, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 12, 2024 •
edited by lurgi
Loading

Original issue description

목적

아토믹 디자인 패턴 도입하여 보다 가독성 있는 디렉토리 구조를 통해 컴포넌트를 사용할 수 있게 합니다.

작업 세부사항

  • 기존의 Components/Common 에 있는 컴포넌트를 Atoms와 Molecules로 구분합니다.
  • 기존의 Components/[Feature] 내부에 있는 Partial한 컴포넌트를 Organisms로 구분합니다.
    • [Feature] 자체가 ORganisms의 역할을 한다고 판단하여 구분하지 않았습니다.
  • 스토리북 디렉토리 구조를 아토믹 구조에 맞게 변경합니다.
  • ChevronButton 삭제
  • �Ellipsis.svg 및 Chevron.svg 삭제

참고 사항

아래의 별표줄 밑에 요구사항 ID만 작성해주세요. Prefix 금지!

COM_ATOMIC

closes #659

@github-actions github-actions bot added frontend 프론트엔드 refactor 기존 코드 수정 labels Sep 12, 2024
@lurgi lurgi marked this pull request as ready for review September 13, 2024 05:23
@github-actions GitHub Actions
Copy link
Contributor Author

1726205012.351899

@github-actions GitHub Actions
Copy link
Contributor Author

1726205020.986999

seongjinme
seongjinme approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@seongjinme seongjinme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

러기 고생 많으셨습니다! 정말 많은 양의 리소스와 코드를 정리해 주셨네요 🙏

llqqssttyy
llqqssttyy requested changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@llqqssttyy llqqssttyy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아토믹 디자인에 대해 학습하고 공유해주셔서 감사합니다, 러기!
체계가 섞여있던 공통 컴포넌트들이 atom과 molecules로 잘 정리되었네요.👍

다만 storybook에서 RadioInputOption이 Common/Molecules가 아니라 Organisms/Molecules로 잘못 들어가 있어서 이 부분만 정정 부탁드릴게요~
(코드에 리뷰로 달면 버벅일까봐 코멘트로 말씀드립니다^^)

image

@lurgi lurgi merged commit 72104d1 into fe/develop Sep 13, 2024
11 checks passed
@lurgi lurgi deleted the fe-659-COM_ATOMIC branch September 13, 2024 09:46
@llqqssttyy llqqssttyy mentioned this pull request Sep 19, 2024
Merged
llqqssttyy pushed a commit that referenced this pull request Sep 19, 2024
@github-actions @lurgi @llqqssttyy
refactor-fe: 아토믹 디자인 패턴 도입 (#660)
05b99eb 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jeongwoo Park <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llqqssttyy llqqssttyy llqqssttyy approved these changes

@seongjinme seongjinme seongjinme approved these changes

Assignees

@lurgi lurgi

Labels
frontend 프론트엔드 refactor 기존 코드 수정
Projects
2024-cruru
Status: 완료
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@llqqssttyy @seongjinme @lurgi