feat-fe: 평가 조회 및 등록 UI 수정 #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
1728550971.867909 |
|
1728550972.074429 |
|
1728550993.020779 |
lurgi
approved these changes
Oct 11, 2024
Comment on lines
17
to
28
| const FormSection = isFormOpened ? ( | ||
| <EvaluationForm | ||
| processId={processId} | ||
| applicantId={applicantId} | ||
| onClose={() => setIsFormOpened(false)} | ||
| /> | ||
| ) : ( | ||
| <EvaluationAddButton onClick={() => setIsFormOpened(true)} /> | ||
| ); | ||
| const FormSection = | ||
| isCurrentProcess && | ||
| (isFormOpened ? ( | ||
| <EvaluationForm | ||
| processId={processId} | ||
| applicantId={applicantId} | ||
| onClose={() => setIsFormOpened(false)} | ||
| /> | ||
| ) : ( | ||
| <EvaluationAddButton onClick={() => setIsFormOpened(true)} /> | ||
| )); |
There was a problem hiding this comment.
저는 JSX구문이 return 이전에 사용되는게 어색한데 렛서는 어떻게 보시나용?!
저는 딱히 이유가 있진 않습니다 ㅎㅎ 그저 어색하게 느껴져용
There was a problem hiding this comment.
음 저는 위와 같이 복잡한 조건부 처리가 필요한 로직은 따로 떼어서 변수화하는 것이 좋다고 생각해요. 예전에 레벨1-2 기간에 리뷰 받았던 내용이기도 합니다.
There was a problem hiding this comment.
음 사실 제가 짠 코드가 아니고 조건만 추가한 거긴 한데요, 저도 return 문 전에 jsx 코드가 있는 것이 문제가 있다고 보진 않습니다.
아쉬운 부분이라면 조건이 하나 더 추가되면서 가독성이 안 좋아진 부분이겠네요. 한번 개선해보겠습니다~
Comment on lines
46
to
48
| Default.parameters = { | ||
| docs: {}, | ||
| }; |
seongjinme
approved these changes
Oct 11, 2024
| @@ -91,6 +91,8 @@ const ResultFlag = styled.div<{ $score: string }>` | |||
| const ResultComment = styled.div` | |||
| ${({ theme }) => theme.typography.common.small}; | |||
| color: ${({ theme }) => theme.colors.text.block}; | |||
| white-space: pre-wrap; | |||
There was a problem hiding this comment.
pre-wrap 설정 좋네요. 띄어쓰기, 들여쓰기, 줄바꿈은 모두 허용하면서 너무 긴 문장은 자동으로 줄바꿈을 해주는 속성이군요. 좋은 속성을 새로 배우고 갑니다 👍
Comment on lines
17
to
28
| const FormSection = isFormOpened ? ( | ||
| <EvaluationForm | ||
| processId={processId} | ||
| applicantId={applicantId} | ||
| onClose={() => setIsFormOpened(false)} | ||
| /> | ||
| ) : ( | ||
| <EvaluationAddButton onClick={() => setIsFormOpened(true)} /> | ||
| ); | ||
| const FormSection = | ||
| isCurrentProcess && | ||
| (isFormOpened ? ( | ||
| <EvaluationForm | ||
| processId={processId} | ||
| applicantId={applicantId} | ||
| onClose={() => setIsFormOpened(false)} | ||
| /> | ||
| ) : ( | ||
| <EvaluationAddButton onClick={() => setIsFormOpened(true)} /> | ||
| )); |
There was a problem hiding this comment.
음 저는 위와 같이 복잡한 조건부 처리가 필요한 로직은 따로 떼어서 변수화하는 것이 좋다고 생각해요. 예전에 레벨1-2 기간에 리뷰 받았던 내용이기도 합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
목적
작업 세부사항
EVAL_05
closes #778