feat-fe: 지원자 이름 검색 #814
Merged
feat-fe: 지원자 이름 검색 #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
1728980488.876559 |
|
1728980498.574779 |
|
1728980672.188229 |
seongjinme
approved these changes
Oct 15, 2024
| () => | ||
| process.applicants.filter(({ applicantName, isRejected }) => { | ||
| const matchesName = searchedName ? applicantName.includes(searchedName) : true; | ||
| const matchesRejection = showRejectedApplicant ? isRejected : !isRejected; |
There was a problem hiding this comment.
지금도 잘 동작하는 로직이지만, 아래와 같이 간략화가 가능할 것 같아요.
Suggested change
| const matchesRejection = showRejectedApplicant ? isRejected : !isRejected; | |
| const matchesRejection = showRejectedApplicant === isRejected; |
There was a problem hiding this comment.
반영했습니다! 꼼꼼하게 봐주셔서 감사해요.
lurgi
approved these changes
Oct 15, 2024
Comment on lines
7
to
9
| const handleName = useCallback((newName: string) => { | ||
| setName(newName); | ||
| }, []); |
There was a problem hiding this comment.
함수 네이밍에서 함수의 역할을 잘 유추가 안되었어요! 그럼에도 함수 자체가 복잡한 기능을 가지진 않는 것 같아 리네이밍 하는 건 렛서의 몫으로 남겨두도록 하겠습니다~!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
목적
구현 사항
참고사항
ProcessColumn을 메모이제이션 했었지만 element가 적은 상황에서는 오히려 committed at(DOM 요소가 표시되기까지의 시간)이 늘어났습니다. 따라서 따로 렌더링 최적화는 진행하지 않았습니다!
SRCH_01
closes #813