feat-be: Redis 로컬 환경 설정 #822
Open
+155
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
cutehumanS2
requested review from
HyungHoKim00,
Chocochip101,
Dobby-Kim and
xogns1514
|
1728982317.884359 |
📌 Test Coverage Report
|
Dobby-Kim
requested changes
Oct 15, 2024
There was a problem hiding this comment.
Test용이라면 test 패키지에 넣어두면 좋을 것 같습니다!
또한, 현재 test controller에 존재하는 메서드에서는 facade 계층을 이용하지 않고 있는데, 추후 추가될 기능을 생각해서 facade도 지금 초안 정도는 만드시는것이 좋을 것 같아요 :>
There was a problem hiding this comment.
제목이 local인 것에 비해 redis만 관리하고 있는 스크립트니까 redis로 파일명을 바꾸거나 따로 local용 docker-compose 파일을 만드시는게 어떨까요?
| image: redis:latest | ||
| container_name: redis-local | ||
| ports: | ||
| - "6379:6379" |
There was a problem hiding this comment.
6379-> 6379로 포트 바인딩을 같은 포트 번호로 하는 것보다
User Port 범위(1024~49151) 내의 임의의 포트를 지정해주는 것이 어떨까요?
로컬에서 모종의 의유로 중복 사용될 수도 있을 것 같아서요
|
|
||
| @RestController | ||
| @RequestMapping("/redis-test") | ||
| public class RedisTestController { |
There was a problem hiding this comment.
이 테스트 클래스에서 key의 life cycle을 관리하는 테스트도 만들어보시는 것이 어떨까요?
저희 메일 인증 기능의 핵심인 것 같아서요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
목적
작업 세부사항
참고사항
각자 로컬에 설치된 도커에서 아래 명령어 실행하면 됩니다(설치되어 있겠죠..?).
레디스 연동 확인 겸 테스트 컨트롤러랑 테스트 코드를 작성해 두었는데요, 맞게 작성했는지 확신은 안 서네요. 😅
/redis-test엔드포인트로 요청 보내면 됩니다.질문
REDIS_01
closes #821