feat-fe: 지원자 정렬 기능 #824
Open
feat-fe: 지원자 정렬 기능 #824
+138
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
1729131205.722389 |
|
1729131208.795249 |
|
1729131210.541489 |
|
1729131216.799889 |
seongjinme
reviewed
Oct 17, 2024
Comment on lines
16
to
19
| const sortOptions: DropdownSortOptions = { | ||
| sortByScore: '평점 높은 순', | ||
| sortByCreatedAt: '지원 날짜 순', | ||
| }; |
There was a problem hiding this comment.
프로세스 관련 타입에는 정렬 옵션에 대해 ASC와 DESC가 모두 정의되어 있는데, 현재는 두 가지 모두 ASC 옵션만 존재하네요. 혹시 "평점 낮은 순"처럼 DESC가 필요할 상황은 없을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
목적
작업 세부사항
참고사항
Dropdown sm 사이즈에 padding 값 변경
상하 패딩이
12px로 설정되어 있는 부분을 피그마 시안에 맞춰8px로 변경했습니다.프로세스 목록 요청 queryKey 설정
queryKey에 sortOption을 추가하면 예상치 못하게 기존 요청도 재요청이 가는 동작을 확인해 queryKey에서 제외하고 useEffect의 sortOption 을 의존성 배열로 추가하고 refetch되도록 처리해놨습니다.
일반적이지 않은 상황이라 주석을 남겼습니다.
SORT_APPL_01
closes #823