[BE] 행사 생성 기능 구현 #41
Merged
[BE] 행사 생성 기능 구현 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arachneee
reviewed
Jul 18, 2024
Comment on lines
+22
to
+24
| return ResponseEntity.ok() | ||
| .location(URI.create("events/" + eventAppResponse.token())) | ||
| .build(); |
There was a problem hiding this comment.
[R] create()를 사용해서 status code를 201로 하는 것은 어떨까요?
201이 아니면 location 헤더가 있는지 예측하기 어려울것 같습니다.
Comment on lines
+6
to
+12
| @Component | ||
| public class EventTokenProvider { | ||
|
|
||
| public String createToken() { | ||
| return UUID.randomUUID().toString(); | ||
| } | ||
| } |
There was a problem hiding this comment.
[R] EventTokenProvider 생성 정책이 바뀔 가능성이 있을 것 같은데 인터페이스로 하는 것은 어떨까요?
test에서도 모킹을 하지 않고 함수형 인터페이스를 활용할 수 있을 것 같아요.
khabh
requested changes
Jul 18, 2024
| private final EventTokenProvider eventTokenProvider; | ||
|
|
||
| public EventAppResponse saveEvent(EventAppRequest request) { | ||
| String token = eventTokenProvider.createToken(); |
There was a problem hiding this comment.
[R] 중복된 토큰이 생성될 수 있으니 저장 전에 검증을 한 번 해 주면 좋을 것 같습니다.
There was a problem hiding this comment.
매 초 100만개의 UUID를 100년동안 생성할때 0.00009% 확률로 중복이 발생합니다. 라고 하는데 굳이 검증을 해야할까요?
DB에서 unique 조건을 한 번 걸어주는 것만으로 충분하다고 생각합니다.
Arachneee
reviewed
Jul 18, 2024
Comment on lines
+24
to
+27
| public Event(String name, String token) { | ||
| this.name = name; | ||
| this.token = token; | ||
| } |
There was a problem hiding this comment.
[R] : name 검증이 없는 것 같아요.
Arachneee
reviewed
Jul 18, 2024
| private final EventService eventService; | ||
|
|
||
| @PostMapping("/api/events") | ||
| public ResponseEntity<Void> saveEvent(EventSaveRequest request) { |
There was a problem hiding this comment.
[R] : @RequestBody 를 안붙여도 잘 동작하나요?
명시적으로 붙이는 것이 어떨까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
구현 사항
행사 생성 API 구현
중점적으로 리뷰받고 싶은 부분(선택)
리뷰 시에 커밋의 규모가 적당했는지 궁금합니다.
논의하고 싶은 부분(선택)
행사 token 생성 전략에 대하여, 임의로 UUID를 선택했습니다. 이후, 변경을 고려하여 EventTokenProvider.class로 분리했습니다. 추후 논의가 필요할 것 같습니다.