♻️ change package for category recipe search

woowacourse-teams · Jul 27, 2024 · 808e701 · 808e701
1 parent b10a175
commit 808e701
Show file tree

Hide file tree

Showing 10 changed files with 191 additions and 170 deletions.
diff --git a/backend/src/main/java/net/pengcook/category/controller/CategoryController.java b/backend/src/main/java/net/pengcook/category/controller/CategoryController.java
diff --git a/backend/src/main/java/net/pengcook/category/service/CategoryService.java b/backend/src/main/java/net/pengcook/category/service/CategoryService.java
@@ -22,22 +22,11 @@ public class CategoryService {
 
     private final CategoryRepository categoryRepository;
     private final CategoryRecipeRepository categoryRecipeRepository;
-    private final RecipeRepository recipeRepository;
-    private final RecipeService recipeService;
 
     public void saveCategories(Recipe recipe, List<String> categories) {
         categories.forEach(category -> saveCategoryRecipe(recipe, category));
     }
 
-    public List<MainRecipeResponse> readRecipesOfCategory(RecipeOfCategoryRequest request) {
-        String categoryName = request.category();
-        Pageable pageable = PageRequest.of(request.pageNumber(), request.pageSize());
-        List<Long> recipeIds = categoryRecipeRepository.findRecipeIdsByCategoryName(categoryName, pageable);
-
-        List<RecipeDataResponse> recipeDataResponses = recipeRepository.findRecipeData(recipeIds);
-        return recipeService.convertToMainRecipeResponses(recipeDataResponses);
-    }
-
     private void saveCategoryRecipe(Recipe recipe, String name) {
         Category category = categoryRepository.findByName(name)
                 .orElseGet(() -> categoryRepository.save(new Category(name)));

diff --git a/backend/src/main/java/net/pengcook/recipe/controller/RecipeController.java b/backend/src/main/java/net/pengcook/recipe/controller/RecipeController.java
@@ -2,10 +2,12 @@
 
 import java.util.List;
 import lombok.RequiredArgsConstructor;
+import net.pengcook.category.dto.RecipeOfCategoryRequest;
 import net.pengcook.recipe.dto.MainRecipeResponse;
 import net.pengcook.recipe.dto.RecipeStepResponse;
 import net.pengcook.recipe.service.RecipeService;
 import org.springframework.web.bind.annotation.GetMapping;
+import org.springframework.web.bind.annotation.ModelAttribute;
 import org.springframework.web.bind.annotation.PathVariable;
 import org.springframework.web.bind.annotation.RequestMapping;
 import org.springframework.web.bind.annotation.RequestParam;
@@ -27,4 +29,9 @@ public List<MainRecipeResponse> readRecipes(@RequestParam int pageNumber, @Reque
     public List<RecipeStepResponse> readRecipeSteps(@PathVariable long id) {
         return recipeService.readRecipeSteps(id);
     }
+
+    @GetMapping("/search")
+    public List<MainRecipeResponse> readRecipesOfCategory(@ModelAttribute RecipeOfCategoryRequest request) {
+        return recipeService.readRecipesOfCategory(request);
+    }
 }
diff --git a/backend/src/main/java/net/pengcook/recipe/service/RecipeService.java b/backend/src/main/java/net/pengcook/recipe/service/RecipeService.java
@@ -5,6 +5,8 @@
 import java.util.List;
 import java.util.stream.Collectors;
 import lombok.RequiredArgsConstructor;
+import net.pengcook.category.dto.RecipeOfCategoryRequest;
+import net.pengcook.category.repository.CategoryRecipeRepository;
 import net.pengcook.recipe.domain.RecipeStep;
 import net.pengcook.recipe.dto.AuthorResponse;
 import net.pengcook.recipe.dto.CategoryResponse;
@@ -24,6 +26,7 @@ public class RecipeService {
 
     private final RecipeRepository recipeRepository;
     private final RecipeStepRepository recipeStepRepository;
+    private final CategoryRecipeRepository categoryRecipeRepository;
 
     public List<MainRecipeResponse> readRecipes(int pageNumber, int pageSize) {
         Pageable pageable = PageRequest.of(pageNumber, pageSize);
@@ -38,6 +41,15 @@ public List<RecipeStepResponse> readRecipeSteps(long id) {
         return convertToRecipeStepResponses(recipeSteps);
     }
 
+    public List<MainRecipeResponse> readRecipesOfCategory(RecipeOfCategoryRequest request) {
+        String categoryName = request.category();
+        Pageable pageable = PageRequest.of(request.pageNumber(), request.pageSize());
+        List<Long> recipeIds = categoryRecipeRepository.findRecipeIdsByCategoryName(categoryName, pageable);
+
+        List<RecipeDataResponse> recipeDataResponses = recipeRepository.findRecipeData(recipeIds);
+        return convertToMainRecipeResponses(recipeDataResponses);
+    }
+
     private List<RecipeStepResponse> convertToRecipeStepResponses(List<RecipeStep> recipeSteps) {
         return recipeSteps.stream()
                 .map(RecipeStepResponse::new)

diff --git a/backend/src/test/java/net/pengcook/category/controller/CategoryControllerTest.java b/backend/src/test/java/net/pengcook/category/controller/CategoryControllerTest.java
diff --git a/backend/src/test/java/net/pengcook/category/service/CategoryServiceTest.java b/backend/src/test/java/net/pengcook/category/service/CategoryServiceTest.java
@@ -6,19 +6,13 @@
 import java.time.LocalDate;
 import java.time.LocalTime;
 import java.util.List;
-import java.util.stream.Stream;
-import net.pengcook.category.dto.RecipeOfCategoryRequest;
 import net.pengcook.category.repository.CategoryRecipeRepository;
 import net.pengcook.category.repository.CategoryRepository;
 import net.pengcook.recipe.domain.Recipe;
-import net.pengcook.recipe.dto.MainRecipeResponse;
 import net.pengcook.recipe.service.RecipeService;
 import net.pengcook.user.domain.User;
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
-import org.junit.jupiter.params.ParameterizedTest;
-import org.junit.jupiter.params.provider.Arguments;
-import org.junit.jupiter.params.provider.MethodSource;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.boot.test.autoconfigure.orm.jpa.DataJpaTest;
 import org.springframework.context.annotation.Import;
@@ -52,27 +46,4 @@ void saveCategories() {
                 () -> assertThat(categoryRecipeRepository.count()).isEqualTo(INITIAL_CATEGORY_RECIPE_COUNT + 2)
         );
     }
-
-    @ParameterizedTest
-    @MethodSource("provideParameters")
-    @DisplayName("특정 카테고리의 레시피를 찾는다.")
-    void readRecipesOfCategory(int pageNumber, int pageSize, List<Long> expected) {
-        RecipeOfCategoryRequest request = new RecipeOfCategoryRequest("한식", pageNumber, pageSize);
-
-        List<MainRecipeResponse> mainRecipeResponses = categoryService.readRecipesOfCategory(request);
-        List<Long> actual = mainRecipeResponses.stream().map(MainRecipeResponse::recipeId).toList();
-
-        assertAll(
-                () -> assertThat(actual.size()).isEqualTo(pageSize),
-                () -> assertThat(actual).containsAll(expected)
-        );
-    }
-
-    static Stream<Arguments> provideParameters() {
-        return Stream.of(
-                Arguments.of(0, 2, List.of(2L, 3L)),
-                Arguments.of(1, 2, List.of(7L, 9L)),
-                Arguments.of(1, 3, List.of(9L, 14L, 15L))
-        );
-    }
 }
diff --git a/backend/src/test/java/net/pengcook/recipe/controller/RecipeControllerTest.java b/backend/src/test/java/net/pengcook/recipe/controller/RecipeControllerTest.java
@@ -1,28 +1,21 @@
 package net.pengcook.recipe.controller;
 
+import static com.epages.restdocs.apispec.RestAssuredRestDocumentationWrapper.document;
 import static org.hamcrest.Matchers.is;
+import static org.springframework.restdocs.payload.PayloadDocumentation.fieldWithPath;
+import static org.springframework.restdocs.payload.PayloadDocumentation.responseFields;
+import static org.springframework.restdocs.request.RequestDocumentation.parameterWithName;
+import static org.springframework.restdocs.request.RequestDocumentation.queryParameters;
 
 import io.restassured.RestAssured;
 import io.restassured.http.ContentType;
-import org.junit.jupiter.api.BeforeEach;
+import net.pengcook.RestDocsSetting;
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
-import org.springframework.boot.test.context.SpringBootTest;
-import org.springframework.boot.test.context.SpringBootTest.WebEnvironment;
-import org.springframework.boot.test.web.server.LocalServerPort;
 import org.springframework.test.context.jdbc.Sql;
 
-@SpringBootTest(webEnvironment = WebEnvironment.RANDOM_PORT)
 @Sql(value = "/data/recipe.sql")
-class RecipeControllerTest {
-
-    @LocalServerPort
-    private int port;
-
-    @BeforeEach
-    void setUp() {
-        RestAssured.port = port;
-    }
+class RecipeControllerTest extends RestDocsSetting {
 
     @Test
     @DisplayName("레시피 개요 목록을 조회한다.")
@@ -45,4 +38,43 @@ void readRecipeSteps() {
                 .then().log().all()
                 .body("size()", is(3));
     }
+
+    @Test
+    @DisplayName("카테고리별 레시피 개요 목록을 조회한다.")
+    void readRecipesOfCategory() {
+        RestAssured.given(spec).log().all()
+                .filter(document(DEFAULT_RESTDOCS_PATH,
+                        queryParameters(
+                                parameterWithName("category").description("카테고리"),
+                                parameterWithName("pageNumber").description("페이지 번호"),
+                                parameterWithName("pageSize").description("페이지 크기")
+                        ),
+                        responseFields(
+                                fieldWithPath("[]").description("레시피 목록"),
+                                fieldWithPath("[].recipeId").description("레시피 아이디"),
+                                fieldWithPath("[].title").description("레시피 제목"),
+                                fieldWithPath("[].author").description("작성자 정보"),
+                                fieldWithPath("[].author.authorId").description("작성자 아이디"),
+                                fieldWithPath("[].author.authorName").description("작성자 이름"),
+                                fieldWithPath("[].author.authorImage").description("작성자 이미지"),
+                                fieldWithPath("[].cookingTime").description("조리 시간"),
+                                fieldWithPath("[].thumbnail").description("썸네일 이미지"),
+                                fieldWithPath("[].difficulty").description("난이도"),
+                                fieldWithPath("[].likeCount").description("좋아요 수"),
+                                fieldWithPath("[].description").description("레시피 설명"),
+                                fieldWithPath("[].category").description("카테고리 목록"),
+                                fieldWithPath("[].category[].categoryId").description("카테고리 아이디"),
+                                fieldWithPath("[].category[].categoryName").description("카테고리 이름"),
+                                fieldWithPath("[].ingredient").description("재료 목록"),
+                                fieldWithPath("[].ingredient[].ingredientId").description("재료 아이디"),
+                                fieldWithPath("[].ingredient[].ingredientName").description("재료 이름"),
+                                fieldWithPath("[].ingredient[].requirement").description("재료 필수 여부")
+                        )))
+                .queryParam("category", "한식")
+                .queryParam("pageNumber", 0)
+                .queryParam("pageSize", 3)
+                .when().get("/api/recipes/search")
+                .then().log().all()
+                .body("size()", is(3));
+    }
 }
diff --git a/backend/src/test/java/net/pengcook/recipe/repository/RecipeRepositoryTest.java b/backend/src/test/java/net/pengcook/recipe/repository/RecipeRepositoryTest.java
@@ -29,21 +29,21 @@ void findRecipeIds() {
 
         List<Long> recipeIds = repository.findRecipeIds(pageable);
 
-        assertThat(recipeIds).containsExactly(4L, 3L, 2L);
+        assertThat(recipeIds).containsExactly(15L, 14L, 13L);
     }
 
     @Test
     @DisplayName("레시피 id에 해당되는 세부 정보를 반환한다.")
     void findRecipeData() {
         List<Long> recipeIds = List.of(4L, 3L);
-        RecipeDataResponse expectedData = new RecipeDataResponse(4, "흰쌀밥", 1, "loki", "loki.jpg", LocalTime.of(0, 40),
-                "흰쌀밥이미지.jpg", 2, 4, "흰쌀밥 조리법", 3, "채식", 2, "쌀", REQUIRED
+        RecipeDataResponse expectedData = new RecipeDataResponse(4, "토마토스파게티", 1, "loki", "loki.jpg", LocalTime.of(0, 30),
+                "토마토스파게티이미지.jpg", 3, 2, "토마토스파게티 조리법", 2, "양식", 2, "쌀", REQUIRED
         );
 
         List<RecipeDataResponse> recipeData = repository.findRecipeData(recipeIds);
 
         assertAll(
-                () -> assertThat(recipeData).hasSize(8),
+                () -> assertThat(recipeData).hasSize(6 + 3),
                 () -> assertThat(recipeData).contains(expectedData)
         );
     }

diff --git a/backend/src/test/java/net/pengcook/recipe/service/RecipeServiceTest.java b/backend/src/test/java/net/pengcook/recipe/service/RecipeServiceTest.java
@@ -1,15 +1,20 @@
 package net.pengcook.recipe.service;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.junit.jupiter.api.Assertions.assertAll;
 
 import java.util.Arrays;
 import java.util.List;
+import java.util.stream.Stream;
+import net.pengcook.category.dto.RecipeOfCategoryRequest;
 import net.pengcook.recipe.dto.MainRecipeResponse;
 import net.pengcook.recipe.dto.RecipeStepResponse;
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.Arguments;
 import org.junit.jupiter.params.provider.CsvSource;
+import org.junit.jupiter.params.provider.MethodSource;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.boot.test.autoconfigure.orm.jpa.DataJpaTest;
 import org.springframework.context.annotation.Import;
@@ -24,7 +29,7 @@ class RecipeServiceTest {
     private RecipeService recipeService;
 
     @ParameterizedTest
-    @CsvSource(value = {"0,2,4", "1,2,2", "1,3,1"})
+    @CsvSource(value = {"0,2,15", "1,2,13", "1,3,12"})
     @DisplayName("요청받은 페이지의 레시피 개요 목록을 조회한다.")
     void readRecipes(int pageNumber, int pageSize, int expectedFirstRecipeId) {
         List<MainRecipeResponse> mainRecipeResponses = recipeService.readRecipes(pageNumber, pageSize);
@@ -46,4 +51,27 @@ void readRecipeSteps() {
 
         assertThat(recipeStepResponses).isEqualTo(expectedRecipeStepResponses);
     }
+
+    @ParameterizedTest
+    @MethodSource("provideParameters")
+    @DisplayName("특정 카테고리의 레시피를 찾는다.")
+    void readRecipesOfCategory(int pageNumber, int pageSize, List<Long> expected) {
+        RecipeOfCategoryRequest request = new RecipeOfCategoryRequest("한식", pageNumber, pageSize);
+
+        List<MainRecipeResponse> mainRecipeResponses = recipeService.readRecipesOfCategory(request);
+        List<Long> actual = mainRecipeResponses.stream().map(MainRecipeResponse::recipeId).toList();
+
+        assertAll(
+                () -> assertThat(actual.size()).isEqualTo(pageSize),
+                () -> assertThat(actual).containsAll(expected)
+        );
+    }
+
+    static Stream<Arguments> provideParameters() {
+        return Stream.of(
+                Arguments.of(0, 2, List.of(2L, 3L)),
+                Arguments.of(1, 2, List.of(7L, 9L)),
+                Arguments.of(1, 3, List.of(9L, 14L, 15L))
+        );
+    }
 }