♻️ change package for category recipe search #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oshyun00
approved these changes
Jul 28, 2024
| List<Long> recipeIds = categoryRecipeRepository.findRecipeIdsByCategoryName(categoryName, pageable); | ||
|
|
||
| List<RecipeDataResponse> recipeDataResponses = recipeRepository.findRecipeData(recipeIds); | ||
| return convertToMainRecipeResponses(recipeDataResponses); |
There was a problem hiding this comment.
카테고리별 조회 로직이 recipe 패키지에 포함돼서 convert 메서드 접근제어자는 다시 private로 바꾸면 좋을 것 같습니다!
| ); | ||
|
|
||
| List<RecipeDataResponse> recipeData = repository.findRecipeData(recipeIds); | ||
|
|
||
| assertAll( | ||
| () -> assertThat(recipeData).hasSize(8), | ||
| () -> assertThat(recipeData).hasSize(6 + 3), |
There was a problem hiding this comment.
제가 작성했던 부분이지만 다시 봐도 검증 방식이 애매하긴 하네요. 🥲 데이터 가져오는 방식이나 쿼리문을 향후 개선하기는 해야할 것 같습니다!
데이터 수정하시느라 고생 많으셨어요.
There was a problem hiding this comment.
해석하느라 초큼 힘들었습니다
하지만 잠깐 들여다보면 알아볼 수 있는 정도기는 했어요~~~
geoje
approved these changes
Jul 29, 2024
| @@ -27,4 +29,9 @@ public List<MainRecipeResponse> readRecipes(@RequestParam int pageNumber, @Reque | |||
| public List<RecipeStepResponse> readRecipeSteps(@PathVariable long id) { | |||
| return recipeService.readRecipeSteps(id); | |||
| } | |||
|
|
|||
| @GetMapping("/search") | |||
| public List<MainRecipeResponse> readRecipesOfCategory(@ModelAttribute RecipeOfCategoryRequest request) { | |||
There was a problem hiding this comment.
이제 슬슬 해당 DTO 안에 validation 을 추가하는 것은 어떠신가요~?
There was a problem hiding this comment.
지금 새로 이슈 파놓고 댓글 완성되면 바로 진행해보겠습니다
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
category 패키지에 있던 카테고리별 레시피 조회 기능을 recipe 패키지로 옮겼습니다.
recipe.sql에 테스트 데이터를 추가하며 깨지는 테스트가 생겨 함께 수정했습니다.
제가 맡았던 도메인이 아닌 부분을 약간 건드려 실수가 있을 수 있습니다.
꼼꼼한 확인 부탁드립니다!!