✨ read comments of recipe #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tackyu
approved these changes
Aug 3, 2024
| import net.pengcook.recipe.domain.Recipe; | ||
| import net.pengcook.user.domain.User; | ||
|
|
||
| @Entity |
There was a problem hiding this comment.
지금은 다른 생성자가 없어서 알아서 만들어주니까 그냥 뒀는데,
생각해보니 어노테이션 이용해서 접근제한자 설정해도 괜찮겠네요!
수정하겠습니다
| String message; | ||
|
|
||
| LocalDateTime createdAt; | ||
| } |
There was a problem hiding this comment.
이런 어이없는 실수를...
확인 감사합니다!!!!!
geoje
approved these changes
Aug 4, 2024
| import net.pengcook.authentication.domain.UserInfo; | ||
| import net.pengcook.comment.domain.Comment; | ||
|
|
||
| public record CommentResponse( |
There was a problem hiding this comment.
추후에 행위가 다르지만 도메인이 같은 DTO가 생길 수도 있으니 클래스명 변경으로 중복을 미리 방지하는 것은 어떤가요~?
긍정적으로 검토 해보겠습니다. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
레시피의 아이디를 받아 댓글을 조회합니다.
이 때 로그인한 유저의 댓글인지를 확인할 수 있어야 삭제 버튼을 노출시킬 수 있어, mine이라는 필드가 존재합니다.
comment.getUser().getId() == userInfo.getId()부분은 나중에 UserInfo로 옮기면 좋을 것 같네요!