✨ create comment on recipe #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tackyu
approved these changes
Aug 5, 2024
| import jakarta.validation.constraints.Min; | ||
| import jakarta.validation.constraints.NotBlank; | ||
|
|
||
| public record CreateCommentRequest(@Min(1) long recipeId, @NotBlank String message) { |
There was a problem hiding this comment.
일관성을 위해 recipeId 검증에 대한 논의가 있으면 좋을 것 같아요!
There was a problem hiding this comment.
모든 Request 필드에 @min(1) 정의해주기 vs 기존 로직에서 존재하지 않는 id 값이라고 알려주는걸로 처리하기
There was a problem hiding this comment.
그러네요 이미 터지네요
후자가 좋다고 생각합니다
지울게요!
geoje
approved these changes
Aug 5, 2024
| @@ -22,4 +28,10 @@ public class CommentController { | |||
| public List<CommentOfRecipeResponse> readComments(@PathVariable long recipeId, @LoginUser UserInfo userInfo) { | |||
| return commentService.readComments(recipeId, userInfo); | |||
| } | |||
|
|
|||
| @PostMapping | |||
| @ResponseStatus(HttpStatus.CREATED) | |||
There was a problem hiding this comment.
응답 상태코드를 CREATED 로 정의하셨다면 location 헤더를 추가해보는 건 어떠신가요>?
There was a problem hiding this comment.
나중에 고려할 필요성이 생길 수 있겠네요!
좋은 의견입니닷
참고하고 있다가 필요해지면 수정하겠습니다!
| .body(request) | ||
| .when().post("api/comments") | ||
| .then().log().all() | ||
| .statusCode(201); |
- move validation position - make and use custom exception
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
레시피에 댓글을 등록합니다!