✨ UserReport #180
Merged
✨ UserReport #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oshyun00
approved these changes
Aug 5, 2024
|
|
||
| private String details; | ||
|
|
||
| private LocalDateTime createdAt; |
There was a problem hiding this comment.
(단순 의견) 저도 레시피 생성하는 과정에서 같은 방식으로 createdAt을 저장하고 있는데요, 이렇게 여러 클래스에서 createdAt을 다루게 되면 @EnableJpaAuditing 도입을 고려해봐도 좋을 것 같습니다!
HaiSeong
approved these changes
Aug 6, 2024
| @@ -77,7 +79,7 @@ void checkUsername() { | |||
| .when().get("/api/user/username/check") | |||
| .then().log().all() | |||
| .statusCode(200) | |||
| .body("available", Matchers.is(true)); | |||
| .body("available", is(true)); | |||
|
|
||
| public UserReportResponse reportUser(long reporterId, UserReportRequest userReportRequest) { | ||
| User reporter = userRepository.findById(reporterId).orElseThrow(); | ||
| User reportee = userRepository.findById(userReportRequest.reporteeId()).orElseThrow(); |
There was a problem hiding this comment.
추후에 NotFoundException이 필요할것 같아 추가햐면 좋아보입니다!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
유저 신고 기능