Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ enhance Grafana settings #183

Merged
merged 6 commits into from
Aug 7, 2024
Merged

♻️ enhance Grafana settings #183

merged 6 commits into from
Aug 7, 2024

Conversation

geoje
Copy link
Contributor

@geoje geoje commented Aug 5, 2024

빠른 도입을 위해 유연하게 열어두었던 그라파나의 여러 설정들을 보안에 맞도록 최대한 제한하였습니다.

  • 알림 시 localhost 로 연결되는 문제 dev.mon.pengcook.net 으로 변경
    • 그라파나 컨테이너에 GF_SERVER_ROOT_URL 환경 변수를 추가하였습니다.
  • dev.pengcook.net/actuator/prometheus 에는 로컬 요청에만 접근 가능
    • ActuatorAccessFilter 클래스를 추가하였습니다.
  • 그라파나를 로그인 없이 사용 불가능 하도록 수정
    • docker compose dev 파일을 수정하였습니다.
  • Spring Actuator Endpoint 를 전부 열어 두었던 부분 grafana 쪽만 열도록 수정
    • applicaiton-(local|dev).yaml 를 수정하였습니다.

Copy link

github-actions bot commented Aug 5, 2024

Overall Project 94.55% -0.4% 🍏
Files changed 71.88% 🍏

File Coverage
ActuatorAccessFilter.java 71.88% -28.13% 🍏

Copy link

github-actions bot commented Aug 6, 2024

Overall Project 94.55% -0.4% 🍏
Files changed 71.88% 🍏

File Coverage
ActuatorAccessFilter.java 71.88% -28.13% 🍏


@Slf4j
@Component
public class ActuatorAccessFilter implements Filter {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

검색중에 @WebFilter 라는 어노테이션을 발견했어요!

WebFilter

url 패턴을 지정할 수 있다는데 가능할지는 모르겠어요! 새양이 고려해보시는것도 좋을것 같아요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
해당 방법을 사용해 본 후 Annotation 을 붙였지만 작동하질 않았습니다...
그리하여 현 상태를 유지하기로 하였습니다!

Copy link

@HaiSeong HaiSeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

새양 수고 많았어요! 따봉추 드립니다!

Copy link

@tackyu tackyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

자세하고 친절한 설명 좋습니다 새양

Copy link

github-actions bot commented Aug 7, 2024

Overall Project 91.87% 🍏

There is no coverage information present for the Files changed

@geoje geoje merged commit 18db22f into be/dev Aug 7, 2024
1 check passed
@geoje geoje deleted the be/feat/176 branch August 7, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE Backend ✨ feature new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants