Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ split transactional function readonly and readwrite #361

Merged
merged 5 commits into from
Sep 23, 2024
Merged

♻️ split transactional function readonly and readwrite #361

merged 5 commits into from
Sep 23, 2024

Conversation

github-actions[bot]
Copy link

closes #360

@github-actions github-actions bot added BE Backend ♻️ refactor refactor labels Sep 18, 2024
@geoje geoje requested review from HaiSeong and hyxrxn and removed request for HaiSeong and hyxrxn September 19, 2024 01:40
@github-actions GitHub Actions
Copy link
Author

Overall Project 92.88% 🍏
File Coverage
CategoryService.java 100% 🍏
IngredientRecipeService.java 100% 🍏
IngredientSubstitutionService.java 100% 🍏
RecipeService.java 100% 🍏
RecipeLikeService.java 100% 🍏
CommentService.java 96.18% 🍏
RecipeStepService.java 95.65% 🍏
IngredientService.java 94.23% 🍏
LoginService.java 93.36% 🍏
UserService.java 93.33% 🍏

@geoje geoje requested review from hyxrxn and HaiSeong and removed request for hyxrxn September 19, 2024 03:13
HaiSeong
HaiSeong approved these changes Sep 21, 2024
View reviewed changes
Copy link

@HaiSeong HaiSeong left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

새양 수고하셨습니다~
다만 몇가지 수정사항이 필요해보이네요~

@github-actions GitHub Actions
Copy link
Author

Overall Project 93.04% 🍏
File Coverage
CategoryService.java 100% 🍏
IngredientRecipeService.java 100% 🍏
IngredientSubstitutionService.java 100% 🍏
RecipeService.java 100% 🍏
RecipeLikeService.java 100% 🍏
CommentService.java 96.18% 🍏
RecipeStepService.java 95.65% 🍏
IngredientService.java 94.23% 🍏
LoginService.java 93.36% 🍏
UserService.java 93.33% 🍏

hyxrxn
hyxrxn approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@hyxrxn hyxrxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오프라인 리뷰로 대신합니다!
LGTM!

@github-actions GitHub Actions
Copy link
Author

Overall Project 93.04% -0.12% 🍏
Files changed 64.29% 🍏

File Coverage
CategoryService.java 100% 🍏
IngredientRecipeService.java 100% 🍏
IngredientSubstitutionService.java 100% 🍏
RecipeService.java 100% 🍏
RecipeLikeService.java 100% 🍏
CommentService.java 96.18% 🍏
RecipeStepService.java 95.65% 🍏
IngredientService.java 94.23% 🍏
LoginService.java 93.36% -2.37% 🍏
UserService.java 93.33% 🍏

@geoje geoje merged commit e62d1eb into be/dev Sep 23, 2024
1 check passed
@geoje geoje deleted the be/feat/360 branch September 23, 2024 11:28
@geoje geoje linked an issue Sep 23, 2024 that may be closed by this pull request
♻️ split transactional function readonly and readwrite #360
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaiSeong HaiSeong HaiSeong approved these changes

@hyxrxn hyxrxn hyxrxn approved these changes

Assignees

@geoje geoje

@HaiSeong HaiSeong

@hyxrxn hyxrxn

Labels
BE Backend ♻️ refactor refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

♻️ split transactional function readonly and readwrite
3 participants
@HaiSeong @hyxrxn @geoje