✨ save categories of recipe #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add method to find category by name
|
HaiSeong
reviewed
Jul 23, 2024
| public class Category { | ||
|
|
||
| @Id | ||
| @GeneratedValue(strategy = GenerationType.IDENTITY) | ||
| private long id; | ||
|
|
||
| private String name; | ||
|
|
||
| public Category(String name) { | ||
| this(0, name); |
There was a problem hiding this comment.
여러분 일관성을 위해 앞으로 둘중 하나로 통일하는건 어떤가요??
this(0, name);this(0L, name);
There was a problem hiding this comment.
토의 결과대로 0L로 변경하도록 하겠습니다~
HaiSeong
reviewed
Jul 23, 2024
|
|
||
| @Entity | ||
| @NoArgsConstructor |
There was a problem hiding this comment.
@NoArgsConstructor에 접근 지정자를 붙여줘도 좋을것 같아요
There was a problem hiding this comment.
그런 기능이 있었군요
좋은 생각입니다
추가하겠습니다~
geoje
approved these changes
Jul 24, 2024
|
|
||
| @DataJpaTest | ||
| @Import(CategoryService.class) | ||
| @AutoConfigureTestDatabase(replace = AutoConfigureTestDatabase.Replace.NONE) |
There was a problem hiding this comment.
혹시 이 부분(23 line)은 무슨 의도 일까용?!
There was a problem hiding this comment.
로키 테스트에서 긁어서 변경 후 사용했는데 저한테는 필요 없는 부분이 딸려왔네요
인메모리 db로도 충분한 테스트인 것 같습니다!
|
oshyun00
approved these changes
Jul 24, 2024
| import org.springframework.data.jpa.repository.JpaRepository; | ||
| import org.springframework.stereotype.Repository; | ||
|
|
||
| @Repository |
There was a problem hiding this comment.
JpaRepository를 상속받고있어서 애너테이션을 제거해도 정상동작할것같은데요, 넣어두신 이유가 궁금합니다!
There was a problem hiding this comment.
JpaRepository면 Spring Data JPA가 알아서 구현체를 주입해주는군요!
처음 알았네요.
빈으로 등록이 안될 것이라 생각하고 붙였습니다.
수정하겠습니다~
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
카테고리명을 List로 받아 각각의 String에 대해 저장 작업을 합니다.
카테고리 하나의 저장 과정은 다음과 같습니다.
먼저 그 String이 카테고리 테이블에 있는지 확인합니다.
있다면 그 카테고리를 가져오고, 없다면 String을 카테고리 테이블에 저장한 후 가져옵니다.
그리고 레시피-카테고리 중간 테이블에 저장합니다.