Skip to content

Commit

Permalink
test: 변경 사항 테스트 반영
Browse files Browse the repository at this point in the history
  • Loading branch information
Kimprodp committed Oct 10, 2024
1 parent 42194bd commit 35ba679
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@ public class ReviewGroupFixture {
}

public static ReviewGroup 리뷰_그룹(String reviewRequestCode, String groupAccessCode) {
return new ReviewGroup("revieweeName", "projectName", reviewRequestCode, groupAccessCode);
return new ReviewGroup("revieweeName", "projectName", reviewRequestCode, groupAccessCode, 1L);
}
}
12 changes: 6 additions & 6 deletions backend/src/test/java/reviewme/reviewgroup/ReviewGroupTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ class ReviewGroupTest {

// when, then
assertAll(
() -> assertThatCode(() -> new ReviewGroup(minLengthName, "project", "reviewCode", "groupCode"))
() -> assertThatCode(() -> new ReviewGroup(minLengthName, "project", "reviewCode", "groupCode", 1L))
.doesNotThrowAnyException(),
() -> assertThatCode(() -> new ReviewGroup(maxLengthName, "project", "reviewCode", "groupCode"))
() -> assertThatCode(() -> new ReviewGroup(maxLengthName, "project", "reviewCode", "groupCode", 1L))
.doesNotThrowAnyException()
);
}
Expand All @@ -37,9 +37,9 @@ class ReviewGroupTest {

// when, then
assertAll(
() -> assertThatCode(() -> new ReviewGroup(insufficientName, "project", "reviewCode", "groupCode"))
() -> assertThatCode(() -> new ReviewGroup(insufficientName, "project", "reviewCode", "groupCode", 1L))
.isInstanceOf(BadRequestException.class),
() -> assertThatThrownBy(() -> new ReviewGroup(exceedName, "project", "reviewCode", "groupCode"))
() -> assertThatThrownBy(() -> new ReviewGroup(exceedName, "project", "reviewCode", "groupCode", 1L))
.isInstanceOf(BadRequestException.class)
);
}
Expand All @@ -54,9 +54,9 @@ class ReviewGroupTest {

// when, then
assertAll(
() -> assertThatThrownBy(() -> new ReviewGroup("reviwee", insufficientName, "reviewCode", "groupCode"))
() -> assertThatThrownBy(() -> new ReviewGroup("reviwee", insufficientName, "reviewCode", "groupCode", 1L))
.isInstanceOf(BadRequestException.class),
() -> assertThatThrownBy(() -> new ReviewGroup("reviwee", exceedName, "reviewCode", "groupCode"))
() -> assertThatThrownBy(() -> new ReviewGroup("reviwee", exceedName, "reviewCode", "groupCode", 1L))
.isInstanceOf(BadRequestException.class)
);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ class ReviewGroupLookupServiceTest {
"ted",
"review-me",
"reviewRequestCode",
"groupAccessCode"
"groupAccessCode",
1L
));

// when
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@
import static org.mockito.BDDMockito.then;
import static org.mockito.Mockito.times;
import static reviewme.fixture.ReviewGroupFixture.리뷰_그룹;
import static reviewme.fixture.TemplateFixture.템플릿;

import java.util.List;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.junit.jupiter.MockitoExtension;
Expand All @@ -21,6 +23,7 @@
import reviewme.reviewgroup.service.dto.ReviewGroupCreationRequest;
import reviewme.reviewgroup.service.dto.ReviewGroupCreationResponse;
import reviewme.support.ServiceTest;
import reviewme.template.repository.TemplateRepository;

@ServiceTest
@ExtendWith(MockitoExtension.class)
Expand All @@ -35,9 +38,13 @@ class ReviewGroupServiceTest {
@Autowired
private ReviewGroupRepository reviewGroupRepository;

@Autowired
private TemplateRepository templateRepository;

@Test
void 코드가_중복되는_경우_다시_생성한다() {
// given
templateRepository.save(템플릿(List.of()));
reviewGroupRepository.save(리뷰_그룹("0000", "1111"));
given(randomCodeGenerator.generate(anyInt()))
.willReturn("0000") // ReviewRequestCode
Expand Down

0 comments on commit 35ba679

Please sign in to comment.