Skip to content

Commit

Permalink
feat: 질문 리뷰이 이름으로 치환
Browse files Browse the repository at this point in the history
Co-authored-by: chysis <[email protected]>
  • Loading branch information
donghoony and chysis committed Aug 8, 2024
1 parent 0b5c3d0 commit 4057438
Show file tree
Hide file tree
Showing 4 changed files with 28 additions and 6 deletions.
10 changes: 5 additions & 5 deletions backend/src/main/java/reviewme/DatabaseInitializer.java
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ public class DatabaseInitializer {
@PostConstruct
@Transactional
void setup() {
questionRepository.save(new Question("팀원을 한줄로 소개해주세요."));
questionRepository.save(new Question("팀원으로부터 배우고 싶은 모습이 있나요?"));
questionRepository.save(new Question("팀원이 없었더라면 우리 팀에는 어떤 점이 부족했을까요?"));
questionRepository.save(new Question("팀원이 다음 목표로 어떤 것을 설정한다면 앞으로의 성장에 더 도움이 될까요?"));
questionRepository.save(new Question("팀원에게 남기고 싶은 말이 있나요? 고맙거나 미안한 점, 응원하고 싶은 점 등 자유롭게 작성해주세요."));
questionRepository.save(new Question("{revieweeName}을 한줄로 소개해주세요."));
questionRepository.save(new Question("{revieweeName}으로부터 배우고 싶은 모습이 있나요?"));
questionRepository.save(new Question("{revieweeName}이 없었더라면 우리 팀에는 어떤 점이 부족했을까요?"));
questionRepository.save(new Question("{revieweeName}이 다음 목표로 어떤 것을 설정한다면 앞으로의 성장에 더 도움이 될까요?"));
questionRepository.save(new Question("{revieweeName}에게 남기고 싶은 말이 있나요? 고맙거나 미안한 점, 응원하고 싶은 점 등 자유롭게 작성해주세요."));

keywordRepository.save(new Keyword("회의를 잘 이끌어요"));
keywordRepository.save(new Keyword("추진력이 좋아요"));
Expand Down
4 changes: 4 additions & 0 deletions backend/src/main/java/reviewme/question/domain/Question.java
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,8 @@ public class Question {
public Question(String content) {
this.content = content;
}

public String convertContent(String target, String replacement) {
return content.replace(target, replacement);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ public ReviewSetupResponse findReviewCreationSetup(String reviewRequestCode) {
private ReviewSetupResponse createReviewSetupResponse(ReviewGroup reviewGroup) {
List<QuestionSetupResponse> questionSetupResponse = questionRepository.findAll()
.stream()
.map(question -> new QuestionSetupResponse(question.getId(), question.getContent()))
.map(question -> new QuestionSetupResponse(question.getId(),
question.convertContent("{revieweeName}", reviewGroup.getReviewee())))
.toList();

List<KeywordResponse> keywordResponse = keywordRepository.findAll()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import reviewme.review.domain.exception.ReviewIsNotInReviewGroupException;
import reviewme.review.dto.request.CreateReviewContentRequest;
import reviewme.review.dto.request.CreateReviewRequest;
import reviewme.review.dto.response.QuestionSetupResponse;
import reviewme.review.dto.response.ReceivedReviewsResponse;
import reviewme.review.dto.response.ReviewDetailResponse;
import reviewme.review.dto.response.ReviewSetupResponse;
Expand Down Expand Up @@ -195,4 +196,20 @@ class ReviewServiceTest {
() -> reviewService.findReceivedReviewDetail(reviewGroup1.getGroupAccessCode(), review2.getId()))
.isInstanceOf(ReviewIsNotInReviewGroupException.class);
}

@Test
void 리뷰_질문_내용에서_특정_문자열을_리뷰이의_이름으로_치환한다() {
// given
reviewGroupRepository.save(
new ReviewGroup("에프이", "리뷰미 프로젝트", "ABCD1234", "1234ABCD")
);
questionRepository.save(new Question("{revieweeName}에게 응원의 메시지를 전해주세요."));

// when
ReviewSetupResponse response = reviewService.findReviewCreationSetup("ABCD1234");
QuestionSetupResponse questionResponse = response.questions().get(0);

// then
assertThat(questionResponse.content()).contains("에프이");
}
}

0 comments on commit 4057438

Please sign in to comment.