Skip to content

Commit

Permalink
refactor: dto 이름 변경
Browse files Browse the repository at this point in the history
  • Loading branch information
Kimprodp committed Aug 1, 2024
1 parent e3783d9 commit 77eb899
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import io.swagger.v3.oas.annotations.media.Schema;

@Schema(name = "리뷰 문항 응답")
public record QuestionResponse(
public record QuestionSetupResponse(

@Schema(description = "리뷰 문항 ID")
long id,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package reviewme.keyword.dto.response;
package reviewme.review.dto.response;

import io.swagger.v3.oas.annotations.media.Schema;

@Schema(name = "키워드 응답")
public record KeywordResponse(
public record ReviewSetUpKeyword(

@Schema(description = "키워드 ID")
long id,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import io.swagger.v3.oas.annotations.media.Schema;
import java.util.List;
import reviewme.keyword.dto.response.KeywordResponse;

@Schema(name = "리뷰 작성 폼 응답")
public record ReviewSetupResponse(
Expand All @@ -14,9 +13,9 @@ public record ReviewSetupResponse(
String projectName,

@Schema(description = "리뷰 문항 목록")
List<QuestionResponse> questions,
List<QuestionSetupResponse> questions,

@Schema(description = "키워드 목록")
List<KeywordResponse> keywords
List<ReviewSetUpKeyword> keywords
) {
}
14 changes: 7 additions & 7 deletions backend/src/main/java/reviewme/review/service/ReviewService.java
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@
import lombok.RequiredArgsConstructor;
import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional;
import reviewme.keyword.dto.response.KeywordResponse;
import reviewme.review.dto.response.ReviewSetUpKeyword;
import reviewme.keyword.repository.KeywordRepository;
import reviewme.review.domain.Review;
import reviewme.review.domain.ReviewContent;
import reviewme.review.domain.ReviewKeyword;
import reviewme.review.dto.request.CreateReviewContentRequest;
import reviewme.review.dto.request.CreateReviewRequest;
import reviewme.review.dto.response.QuestionResponse;
import reviewme.review.dto.response.QuestionSetupResponse;
import reviewme.review.dto.response.ReviewSetupResponse;
import reviewme.review.repository.QuestionRepository;
import reviewme.review.repository.ReviewContentRepository;
Expand Down Expand Up @@ -80,17 +80,17 @@ public ReviewSetupResponse findReviewCreationSetup(String reviewRequestCode) {
}

private ReviewSetupResponse createReviewSetupResponse(ReviewGroup reviewGroup) {
List<QuestionResponse> questionResponses = questionRepository.findAll()
List<QuestionSetupResponse> questionSetupRespons = questionRepository.findAll()
.stream()
.map(question -> new QuestionResponse(question.getId(), question.getContent()))
.map(question -> new QuestionSetupResponse(question.getId(), question.getContent()))
.toList();

List<KeywordResponse> keywordResponses = keywordRepository.findAll()
List<ReviewSetUpKeyword> reviewSetUpKeywordRespons = keywordRepository.findAll()
.stream()
.map(keyword -> new KeywordResponse(keyword.getId(), keyword.getContent()))
.map(keyword -> new ReviewSetUpKeyword(keyword.getId(), keyword.getContent()))
.toList();

return new ReviewSetupResponse(reviewGroup.getReviewee(), reviewGroup.getProjectName(),
questionResponses, keywordResponses);
questionSetupRespons, reviewSetUpKeywordRespons);
}
}

0 comments on commit 77eb899

Please sign in to comment.