refactor: 예외명 명확하게 수정

woowacourse-teams · Aug 11, 2024 · 93aec4d · 93aec4d
1 parent 6241cdc
commit 93aec4d
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/...ception/OptionGroupNotFoundException.java → ...ssingOptionGroupForQuestionException.java b/...ception/OptionGroupNotFoundException.java → ...ssingOptionGroupForQuestionException.java
@@ -4,9 +4,9 @@
 import reviewme.global.exception.NotFoundException;
 
 @Slf4j
-public class OptionGroupNotFoundException extends NotFoundException {
+public class MissingOptionGroupForQuestionException extends NotFoundException {
 
-    public OptionGroupNotFoundException(long questionId) {
+    public MissingOptionGroupForQuestionException(long questionId) {
         super("질문에 해당하는 체크박스 그룹을 찾을 수 없어요.");
         log.info("OptionGroup not found for questionId: {}", questionId);
     }

diff --git a/backend/src/main/java/reviewme/question/repository/OptionGroupRepository.java b/backend/src/main/java/reviewme/question/repository/OptionGroupRepository.java
@@ -3,14 +3,14 @@
 import java.util.Optional;
 import org.springframework.data.jpa.repository.JpaRepository;
 import reviewme.question.domain.OptionGroup;
-import reviewme.question.domain.exception.OptionGroupNotFoundException;
+import reviewme.question.domain.exception.MissingOptionGroupForQuestionException;
 
 public interface OptionGroupRepository extends JpaRepository<OptionGroup, Long> {
 
     Optional<OptionGroup> findByQuestionId(long questionId);
 
     default OptionGroup getByQuestionId(long questionId) {
         return findByQuestionId(questionId)
-                .orElseThrow(() -> new OptionGroupNotFoundException(questionId));
+                .orElseThrow(() -> new MissingOptionGroupForQuestionException(questionId));
     }
 }
diff --git a/backend/src/main/java/reviewme/review/domain/TextAnswers.java b/backend/src/main/java/reviewme/review/domain/TextAnswers.java
@@ -5,7 +5,7 @@
 import java.util.function.Function;
 import java.util.stream.Collectors;
 import lombok.extern.slf4j.Slf4j;
-import reviewme.review.domain.exception.TextAnswerNotFoundException;
+import reviewme.review.domain.exception.MissingTextAnswerForQuestionException;
 
 @Slf4j
 public class TextAnswers {
@@ -19,7 +19,7 @@ public TextAnswers(List<TextAnswer> textAnswers) {
 
     public TextAnswer getAnswerByQuestionId(long questionId) {
         if (!textAnswers.containsKey(questionId)) {
-            throw new TextAnswerNotFoundException(questionId);
+            throw new MissingTextAnswerForQuestionException(questionId);
         }
         return textAnswers.get(questionId);
     }

diff --git a/...xception/TextAnswerNotFoundException.java → ...issingTextAnswerForQuestionException.java b/...xception/TextAnswerNotFoundException.java → ...issingTextAnswerForQuestionException.java
@@ -4,9 +4,9 @@
 import reviewme.global.exception.NotFoundException;
 
 @Slf4j
-public class TextAnswerNotFoundException extends NotFoundException {
+public class MissingTextAnswerForQuestionException extends NotFoundException {
 
-    public TextAnswerNotFoundException(long questionId) {
+    public MissingTextAnswerForQuestionException(long questionId) {
         super("질문에 해당하는 서술형 답변을 찾지 못했어요.");
         log.warn("Text Answer not found for questionId: {}", questionId);
     }

diff --git a/backend/src/test/java/reviewme/review/domain/TextAnswersTest.java b/backend/src/test/java/reviewme/review/domain/TextAnswersTest.java
@@ -5,7 +5,7 @@
 
 import java.util.List;
 import org.junit.jupiter.api.Test;
-import reviewme.review.domain.exception.TextAnswerNotFoundException;
+import reviewme.review.domain.exception.MissingTextAnswerForQuestionException;
 
 class TextAnswersTest {
 
@@ -16,7 +16,7 @@ class TextAnswersTest {
 
         // when, then
         assertThatThrownBy(() -> textAnswers.getAnswerByQuestionId(2))
-                .isInstanceOf(TextAnswerNotFoundException.class);
+                .isInstanceOf(MissingTextAnswerForQuestionException.class);
     }
 
     @Test