-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE] 리뷰 상세 페이지에 react-query 추가 및 리팩토링 #161
Merged
BadaHertz52
merged 36 commits into
develop
from
fe/feat/138-detailed_review_page_refactor
Aug 1, 2024
Merged
Changes from 2 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
e3eaa42
fix: src/index.tsx에서 enableMocking 제거
BadaHertz52 0cb8d19
feat: 리뷰 그룹 생성 시 코멘트 컴포넌트명 변경 및 기본값 설정
BadaHertz52 0a4cec6
refactor: 서버 DB에 있는 리뷰 데이터를 사용하기 위한 상수화
BadaHertz52 19fa32b
feat : QueryClient, QueryClientProvider 적용
BadaHertz52 339c22c
fix: dependencies에 있는 테스트 패키지들을 devDependencies로 옮김
BadaHertz52 90f1784
feat: 리뷰 상세페이지에 react-query 적용
BadaHertz52 f2e96a7
feat : msw에 리뷰 상세페이지 404 오류 추가
BadaHertz52 9721bda
ci: react-error-boundary 설치
BadaHertz52 9e31285
feat: Outlet에 QueryErrorResetBoundary,ErrorBoundary, Suspense 적용
BadaHertz52 251af38
feat: 리뷰 상세페이지에 useSuspenseQuery 적용
BadaHertz52 e45ddb4
refactor: 리뷰 상세페이지 resource, queryString key 상수화
BadaHertz52 41d8fb8
refactor: 리뷰 상세페이지 react-query key 상수화
BadaHertz52 54d927c
refactor: 리뷰 상세 페이지 컴포넌트 속에서만 사용하는 상수들 상수화
BadaHertz52 df18d3a
refactor: DetailedReviewPage/components에 index.tsx를 추가해 import 경로 간결하…
BadaHertz52 da20f40
fix: src/index.tsx에서 enableMocking 삭제
BadaHertz52 3783ed7
feat: error 전파를 위한 QueryClient 옵션 추가
BadaHertz52 80ca5a2
Merge branch 'develop' of https://github.com/woowacourse-teams/2024-r…
BadaHertz52 528eb22
Merge branch 'develop' of https://github.com/woowacourse-teams/2024-r…
BadaHertz52 6af1a65
fix: ErrorPage의 SideModal에 closeModal props로 줌
BadaHertz52 91d0a55
refactor: ErrorSection 위치 변경(src/pages/ErrorPage -> src/components/er…
BadaHertz52 d13fdfd
feat: ErrorFallback 컴포넌트 생성
BadaHertz52 f20698f
feat: ErrorSuspenseContainer 생성 및 App.tsx에 적용
BadaHertz52 f552fcf
chore: constants/index.ts export 경로 변경
BadaHertz52 d6d7696
chore: 3차-1주차 핵심 기능 시현 때 필요 없는 코드 주석 처리
BadaHertz52 9745350
docs: ErrorPage의 ERROR_MESSAGE 수정
BadaHertz52 67e2c5a
design: formWidth 변경 및 fontSize에 1.4rem 추가
BadaHertz52 4415a36
feat: 리뷰 상세 페이지에 리뷰이 이름 추가
BadaHertz52 872ff0b
refactor: 불필요한 export 삭제
BadaHertz52 bc93a51
chore: type명 수정 (RevieweeCommentProps =>RevieweeCommentsProps)
BadaHertz52 3032874
refactor: ErrorSection으l Button 수정
BadaHertz52 52f8de6
refactor: 리뷰 상세 페이지 데이터 타입 변경에 따른 수정
BadaHertz52 c148246
refactor: ErrorSuspenseContainer 적용 위치 변경
BadaHertz52 0da75a9
refactor: 리뷰 상세 페이지 데이터 타입 강제 방법 변경
BadaHertz52 88a2c23
chore: 불필요한 주석 삭제
BadaHertz52 79ee76b
refactor: ErrorSection의 buttons 네이밍 변경 및 요소에 key 추가
BadaHertz52 abe9154
chore: 스타일 주석에 NOTE 추가
BadaHertz52 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
무사히 적용돼서 다행입니다!!