Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] feat: 초기 데이터 세팅 #311

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

skylar1220
Copy link
Contributor


🚀 어떤 기능을 구현했나요 ?

  • 초기 데이터를 세팅했습니다.

🔥 어떻게 해결했나요 ?

  • DataInitializer를 통해 세팅해주었습니다.

📝 어떤 부분에 집중해서 리뷰해야 할까요?

  • 개행 등 리팩토링은 일단 올리고 할게요!

📚 참고 자료, 할 말

@skylar1220 skylar1220 added this to the 4차 스프린트: 최종 milestone Aug 12, 2024
@skylar1220 skylar1220 self-assigned this Aug 12, 2024
@skylar1220 skylar1220 linked an issue Aug 12, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Aug 12, 2024

Test Results

57 tests  ±0   57 ✅ ±0   2s ⏱️ ±0s
22 suites ±0    0 💤 ±0 
22 files   ±0    0 ❌ ±0 

Results for commit 7a121cd. ± Comparison against base commit c2b75de.

♻️ This comment has been updated with latest results.

private final QuestionRepository questionRepository;
private final KeywordRepository keywordRepository;
public static final String CATEGORY_HEADER = "이제, 선택한 순간들을 바탕으로 {revieweeName}에 대한 리뷰를 작성해볼게요.";
public static final String CATEGORY_TEXT_QUESTYION = "위에서 선택한 사항에 대해 조금 더 자세히 설명해주세요.";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오타 있습니다~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

퀘스티온~



long checkBoxCommunicationQuestionId = questionRepository.save(new Question2(true, QuestionType.CHECKBOX,
"커뮤니케이션, 협업 능력에서 어떤 부분이 인상 깊었는지 선택해주세요. (1개 이상)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1개 이상은 프론트에서 받아주지 않나요 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아차차 반영했습니다~

"상황을 자세하게 기록할수록 {revieweeName}에게 도움이 돼요. 어떤 문제 상황이 발생했고, {revieweeName}이/가 어떻게 해결했는지 그 과정을 떠올려 보세요.", 2)).getId();
long problemSolvingSectionId = sectionRepository.save(new Section(VisibleType.CONDITIONAL, List.of(checkBoxProblemSolvingQuestionId, textProblemSolvingQuestionId),
problemSolvingOptionId, CATEGORY_HEADER, 3)).getId();
long problemSolvingOptionGroupId = optionGroupRepository.save(new OptionGroup(checkBoxProblemSolvingQuestionId, 1, 20)).getId();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

옵션 그룹 최대 개수는 옵션 개수와 같게 해주세요

@donghoony
Copy link
Contributor

텍스트 대치하는 것도 이 브랜치에서 진행할게요 ~

Copy link
Contributor

@Kimprodp Kimprodp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

o((⊙﹏⊙))o.

private final QuestionRepository questionRepository;
private final KeywordRepository keywordRepository;
public static final String CATEGORY_HEADER = "이제, 선택한 순간들을 바탕으로 {revieweeName}에 대한 리뷰를 작성해볼게요.";
public static final String CATEGORY_TEXT_QUESTION = "위에서 선택한 사항에 대해 조금 더 자세히 설명해주세요.";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오? 간략하시네요?

@skylar1220 skylar1220 merged commit d359fd1 into develop Aug 12, 2024
4 of 5 checks passed
@donghoony donghoony deleted the be/feature/305-data-initializer-setting branch August 16, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BE] 초기 데이터를 세팅한다.
4 participants