Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] docs: Swagger API 문서 업데이트 #313

Merged
merged 14 commits into from
Aug 12, 2024

Conversation

Kimprodp
Copy link
Contributor


🚀 어떤 기능을 구현했나요 ?

  • 변경된 도메인 구조 설계에 맞게 Swagger API 문서를 업데이트 했습니다.

🔥 어떻게 해결했나요 ?

  • dto와 controller에 Swagger 어노테이션을 붙였죠

📝 어떤 부분에 집중해서 리뷰해야 할까요?

  • api 문서 확인해주세요.

📚 참고 자료, 할 말

  • 눈 아프네요 빨리 api 문서 어떤식으로 할지 정해야 할듯
  • ps. dto 컨벤션도 ..

Copy link

github-actions bot commented Aug 12, 2024

Test Results

57 tests  ±0   57 ✅ ±0   2s ⏱️ ±0s
22 suites ±0    0 💤 ±0 
22 files   ±0    0 ❌ ±0 

Results for commit c92c011. ± Comparison against base commit 0eda785.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@donghoony donghoony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스웨거 슬슬 아니다 싶네요 🤔 테드 고생했습니다! Json 깊이 깊어지면 어떤 식으로 하면 좋을지 생각 진짜 해봐야겠어요.

Copy link
Contributor

@skylar1220 skylar1220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스웩있네요~

…cs/306-swagger-api-update-v2

# Conflicts:
#	backend/src/main/java/reviewme/template/service/TemplateMapper.java
…cs/306-swagger-api-update-v2

# Conflicts:
#	backend/src/main/java/reviewme/review/service/dto/response/detail/QuestionAnswerResponse.java
Copy link
Contributor

@donghoony donghoony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어어어 푸푸푸 또 허허허 우우우적

Copy link
Contributor

@skylar1220 skylar1220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

찐최종마지막

@Kimprodp Kimprodp merged commit 40188a2 into develop Aug 12, 2024
4 of 5 checks passed
@donghoony donghoony deleted the be/docs/306-swagger-api-update-v2 branch August 20, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BE] 구현된 내용으로 Swagger API 문서를 업데이트 한다. (v2)
4 participants