[FE] refactor: 리뷰 상세 페이지 url path 관련 코드 수정 및 리팩터링 #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: badahertz52 <[email protected]> Co-Authored-By: ImxYJL <[email protected]> Co-Authored-By: Fe <[email protected]>
Co-Authored-By: badahertz52 <[email protected]> Co-Authored-By: ImxYJL <[email protected]> Co-Authored-By: Fe <[email protected]>
1 task
Co-Authored-By: badahertz52 <[email protected]> Co-Authored-By: ImxYJL <[email protected]> Co-Authored-By: Fe <[email protected]>
Co-Authored-By: badahertz52 <[email protected]> Co-Authored-By: ImxYJL <[email protected]> Co-Authored-By: Fe <[email protected]>
soosoo22
changed the title
Co-Authored-By: badahertz52 <[email protected]> Co-Authored-By: ImxYJL <[email protected]> Co-Authored-By: Fe <[email protected]>
soosoo22
requested review from
BadaHertz52,
chysis and
ImxYJL
and removed request for
chysis
donghoony
deleted the
fe/refactor/319-detailed-review-page-updated-path
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 어떤 기능을 구현했나요 ?
🔥 어떻게 해결했나요 ?
리뷰 상세 페이지에서 리뷰를 불러오는 API가 변경되어
memberId가 더이상 필요하지 않게 되었습니다. 그래서memberId관련 코드를 모두 제거했습니다.변경사항
getDetailedReviewApi와 관련된 코드에서memberId파라미터를 제거하고, 관련된 모든 사용처에서도memberId를 삭제했습니다.memberId관련 로직을 제거했습니다.ReviewListPage에서 리뷰 클릭 시,navigate경로에memberId를 제거했습니다.리팩터링
REVIEW_MESSAGE_SUFFIX에서 님을 제외하여 "에게 달린 리뷰입니다!"로 수정했습니다.REVIEWEENAME상수를 대문자로 변경했습니다.리뷰 상세 페이지 개선
key값을questionId로 변경했습니다.📝 어떤 부분에 집중해서 리뷰해야 할까요?
memberId관련 코드가 모두 삭제되었을까요?📚 참고 자료, 할 말