Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] refactor: URLGeneratorForm에 useModals 훅 적용 #331

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

ImxYJL
Copy link
Contributor

@ImxYJL ImxYJL commented Aug 13, 2024


🚀 어떤 기능을 구현했나요 ?

  • 제목이 곧 내용

🔥 어떻게 해결했나요 ?

  • 모달을 사용하고 있는 URLGeneratorFormuseModals훅을 적용해서 모달을 열고 닫는 상태와 동작을 훅에 위임했습니다.

📝 어떤 부분에 집중해서 리뷰해야 할까요?

📚 참고 자료, 할 말

Copy link
Contributor

@chysis chysis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모달 상태 관리가 깔끔해졌네요!🐎

Copy link
Contributor

@soosoo22 soosoo22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어요 올리!

Copy link
Contributor

@BadaHertz52 BadaHertz52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어요!

@ImxYJL ImxYJL merged commit 81285af into develop Aug 13, 2024
4 checks passed
@donghoony donghoony deleted the fe/refactor/330-review-group-data-modal-usemodal branch August 20, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FE] ReviewGroupDataModal에 useModal 훅을 적용한다.
4 participants