[BE] refactor: v1 API를 삭제, 엔티티 통합 및 사용하지 않는 클래스 제거 #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results48 tests 48 ✅ 2s ⏱️ Results for commit 9703914. |
skylar1220
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
keword 패키지에 category라는 도메인이 남아있는데 사용하지 않는 도메인이니까 이 브랜치에서 삭제해도 되겠네요ㅎㅎ
skylar1220
reviewed
Aug 15, 2024
There was a problem hiding this comment.
list, detail 나눈 것 너무 좋네요!
nayonsoso
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 어떤 기능을 구현했나요 ?
🔥 어떻게 해결했나요 ?
Question2,Review2와 같은 클래스를 모두 통합했어요. Response도 마찬가지입니다.Repository위치를 적절하게 옮겼습니다.📝 어떤 부분에 집중해서 리뷰해야 할까요?