[BE] refactor: 초기 데이터 설정시 중복 삽입 방지, 선택지 최대 개수 적용 #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results48 tests 48 ✅ 2s ⏱️ Results for commit 3cae680. ♻️ This comment has been updated with latest results. |
Kimprodp
approved these changes
Aug 17, 2024
| @@ -37,10 +39,15 @@ public class DatabaseInitializer { | |||
| @PostConstruct | |||
| @Transactional | |||
| void setup() { | |||
| // 템플릿이 이미 존재하면 종료 | |||
| if (templateRepository.existsById(1L)) { | |||
There was a problem hiding this comment.
기본으로 사용할 템플릿이 추후 변경될 것을 고려하여 id를 상수로 빼서 관리하는 것은 어떨까요?
There was a problem hiding this comment.
#405 (comment)
산초의 피드백으로 적용해보려고해요!
donghoony
approved these changes
Aug 17, 2024
donghoony
changed the title
nayonsoso
approved these changes
Aug 18, 2024
Comment on lines
+29
to
+31
| private static final String CATEGORY_TEXT_QUESTION = "위에서 선택한 사항과 관련된 경험을 구체적으로 적어 주세요."; | ||
| private static final int KEYWORD_CHECKBOX_MIN_COUNT = 1; | ||
| private static final int KEYWORD_CHECKBOX_MAX_COUNT = 3; |
| @@ -37,10 +39,15 @@ public class DatabaseInitializer { | |||
| @PostConstruct | |||
| @Transactional | |||
| void setup() { | |||
| // 템플릿이 이미 존재하면 종료 | |||
| if (templateRepository.existsById(1L)) { | |||
There was a problem hiding this comment.
[테드 의견도 좋고 그냥 말해보는 의견]
요 부분은 templateRepository.findAll().size() > 1 이렇게 가져가도 좋을 것 같아요 ㅎㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 어떤 기능을 구현했나요 ?
🔥 어떻게 해결했나요 ?
📝 어떤 부분에 집중해서 리뷰해야 할까요?
📚 참고 자료, 할 말