Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] fix: 리뷰 연결 페이지 이름 수정 및 EyeButton이 가려지는 문제 해결 #428

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

ImxYJL
Copy link
Contributor

@ImxYJL ImxYJL commented Aug 19, 2024


🚀 어떤 기능을 구현했나요 ?

  • 급해서 제목이 곧 내용입니다

🔥 어떻게 해결했나요 ?

  • input에 padding-right를 줬습니다.
  • ReviewDashboard를 ReviewZone으로 수정했습니다.

📝 어떤 부분에 집중해서 리뷰해야 할까요?

  • Dashboard -> ReviewZone 수정 빼먹은 거 있을까요??

📚 참고 자료, 할 말

Copy link
Contributor

@BadaHertz52 BadaHertz52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀🚀

<S.PasswordInputContainer>
<Input
id="password"
value={password}
onChange={handlePasswordInputChange}
type={isOff ? 'password' : 'text'}
placeholder="abc123"
$style={{ flex: '8' }}
$style={{ width: '100%', paddingRight: '3rem' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리팩토링 시, 눈 모양 이모티콘 크기를 상수 처림하면 좋을 것 같아요.

Copy link
Contributor

@chysis chysis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

조금 더 완성도 있는 페이지가 되었어요👍🐎

Copy link
Contributor

@soosoo22 soosoo22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

올리! 수고했어요!!

@BadaHertz52 BadaHertz52 merged commit 7c3abfb into develop Aug 19, 2024
4 checks passed
@donghoony donghoony deleted the fe/fix/422-password-input-fix branch August 20, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
4 participants