Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE] fix: 리뷰 제출 전 확인 모달 스타일 조정 #440

Merged
merged 2 commits into from
Aug 20, 2024
Merged

[FE] fix: 리뷰 제출 전 확인 모달 스타일 조정 #440

merged 2 commits into from
Aug 20, 2024

Conversation

ImxYJL
Copy link
Contributor

@ImxYJL ImxYJL commented Aug 19, 2024 •
edited
Loading

🚀 어떤 기능을 구현했나요 ?

  • 객관식과 서술형 질문이 너무 붙어있었던 문제를 수정했습니다.
    image

🔥 어떻게 해결했나요 ?

  • 서술형 질문을 스타일이 적용된 태그로 감쌌습니다.

📝 어떤 부분에 집중해서 리뷰해야 할까요?

  • 스타일이 괜찮은지 봐주세요~~
    image

📚 참고 자료, 할 말

  • 네비게이션 바가 추가되면서 경로 안내 컴포넌트와 리뷰 작성 페이지 사이의 gap이 좁아졌어요!!
    image

@ImxYJL ImxYJL added this to the 4차 스프린트: 최종 milestone Aug 19, 2024
@ImxYJL ImxYJL self-assigned this Aug 19, 2024
@ImxYJL ImxYJL linked an issue Aug 19, 2024 that may be closed by this pull request
[FE] AnswerListRecheckModal의 스타일을 수정한다. #357
Closed
BadaHertz52
BadaHertz52 approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@BadaHertz52 BadaHertz52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제출 적 확인 모달 스타일 수정까지 하다니!!!👍

작성페이지 갭도 수정해야겠네요

chysis
chysis approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@chysis chysis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

꼼꼼하게 스타일도 수정해주었네요! 👍

soosoo22
soosoo22 approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@soosoo22 soosoo22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제출 전 확인 모달 스타일 수정하느라 수고했어요 올리!
확실히 문항과 답변이 분리되어 있어서 보기 편하네요!

@soosoo22 soosoo22 merged commit 67fc09e into develop Aug 20, 2024
5 checks passed
@donghoony donghoony deleted the fe/refactor/357-answer-list-recheck-modal-style branch August 23, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chysis chysis chysis approved these changes

@BadaHertz52 BadaHertz52 BadaHertz52 approved these changes

@soosoo22 soosoo22 soosoo22 approved these changes

Assignees

@ImxYJL ImxYJL

Labels
우선순위: 중 🍀 FE 🐛 버그 🛠️ 리팩터링
Projects
2024-review-me
Status: Done
Milestone
4차 스프린트: 최종
Development

Successfully merging this pull request may close these issues.

[FE] AnswerListRecheckModal의 스타일을 수정한다.
4 participants
@ImxYJL @chysis @BadaHertz52 @soosoo22