-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE] refactor: 단건 리뷰 조회 시 리뷰어 정보 삭제, 리뷰 작성 시점 추가 #65
Changes from 2 commits
dd8e05c
09d47e8
d239727
c44dd9a
d7ac47d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. service 패키지에서 빠진 것 같아요! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oops 이동했어요~ |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -96,7 +96,7 @@ class ReviewServiceTest { | |
"그룹 설명", | ||
LocalDateTime.of(2024, 1, 1, 1, 1)) | ||
); | ||
Review review = reviewRepository.save(new Review(reviewer, reviewerGroup)); | ||
Review review = reviewRepository.save(new Review(reviewer, reviewerGroup, LocalDateTime.now())); | ||
|
||
// when | ||
ReviewResponse response = reviewService.findReview(review.getId()); | ||
|
@@ -151,21 +151,23 @@ class ReviewServiceTest { | |
List.of() | ||
); | ||
|
||
reviewRepository.save(new Review(reviewer, reviewerGroup)); | ||
reviewRepository.save(new Review(reviewer, reviewerGroup, LocalDateTime.now())); | ||
|
||
// when, then | ||
assertThatThrownBy(() -> reviewService.createReview(createReviewRequest)) | ||
.isInstanceOf(ReviewAlreadySubmittedException.class); | ||
} | ||
|
||
|
||
@Test | ||
void 데드라인이_지난_리뷰그룹에_대해_리뷰를_작성하려하면_예외가_발생한다() { | ||
// given | ||
memberRepository.save(new Member("산초", "sancho")); | ||
Member reviewee = memberRepository.save(new Member("아루", "aru")); | ||
LocalDateTime createdAt = LocalDateTime.now().minusDays(7).minusMinutes(1); | ||
reviewerGroupRepository.save( | ||
ReviewerGroup reviewerGroup = reviewerGroupRepository.save( | ||
new ReviewerGroup(reviewee, "그룹A", "그룹 설명", createdAt) | ||
); | ||
githubReviewerGroupRepository.save(new GithubReviewerGroup("sancho", reviewerGroup)); | ||
Keyword keyword = keywordRepository.save(new Keyword("꼼꼼해요")); | ||
|
||
CreateReviewContentRequest contentRequest = new CreateReviewContentRequest( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이번 변경 내용은 아니나, 이 부분은 해당 테스트에 필요하지 않은 given절인 것 같아 제거하면 좋을 것 같네요! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 수정했어요~ |
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
validateIsDeadlinePassed(reviewerGroup)
내부에서LocalDateTime.now()
을 통해 데드라인을 검증하고 있는데요.LocalDateTime.now()
를 두 번 사용하는 것 보다 변수로 뽑아서 사용하는 것은 어떨까요?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
추후 수정 하겠읍니다.. 🥹