-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE] feat: 받은 리뷰 요약 조회 API 구현 #796
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
95be71e
feat: 리뷰 요약 조회 기능 구현
Kimprodp 73f587d
test: 리뷰 요약 조회 기능 테스트 작성
Kimprodp 530cebb
test: 리뷰 그룹 픽스쳐 사용하도록 변경
Kimprodp 3231afa
test: 리뷰 요약 조회 테스트에서 list 수를 확인하도록 변경
Kimprodp cc6e147
test: 리뷰 요약 정보 조회 테스트에 다른 그룹 추가하는 조건 설정
Kimprodp 8b0742c
refactor: Transactional 설정
Kimprodp 6533eb8
style: 개행
Kimprodp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 19 additions & 1 deletion
20
backend/src/main/java/reviewme/review/service/ReviewSummaryService.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,30 @@ | ||
package reviewme.review.service; | ||
|
||
import lombok.RequiredArgsConstructor; | ||
import org.springframework.stereotype.Service; | ||
import reviewme.review.repository.ReviewRepository; | ||
import reviewme.review.service.dto.response.list.ReceivedReviewsSummaryResponse; | ||
import reviewme.review.service.exception.ReviewGroupNotFoundByReviewRequestCodeException; | ||
import reviewme.reviewgroup.domain.ReviewGroup; | ||
import reviewme.reviewgroup.repository.ReviewGroupRepository; | ||
|
||
@Service | ||
@RequiredArgsConstructor | ||
public class ReviewSummaryService { | ||
|
||
private final ReviewGroupRepository reviewGroupRepository; | ||
private final ReviewRepository reviewRepository; | ||
|
||
public ReceivedReviewsSummaryResponse getReviewSummary(String reviewRequestCode) { | ||
return null; | ||
ReviewGroup reviewGroup = reviewGroupRepository.findByReviewRequestCode(reviewRequestCode) | ||
.orElseThrow(() -> new ReviewGroupNotFoundByReviewRequestCodeException(reviewRequestCode)); | ||
|
||
int totalReviewCount = reviewRepository.countByReviewGroupId(reviewGroup.getId()); | ||
|
||
return new ReceivedReviewsSummaryResponse( | ||
reviewGroup.getProjectName(), | ||
reviewGroup.getReviewee(), | ||
totalReviewCount | ||
); | ||
Comment on lines
+26
to
+30
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [이건 그냥 소감] |
||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
인덱스 걸려있으면 빠를까요? 아래 JPQL과 쿼리 차이나 성능 차이가 있을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewGroupId에 인덱스 걸려있어서 현재 쿼리로 인덱스 걸리지 않나요?