Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] feat: 리뷰 모아보기 API 구현 #806

Merged
merged 41 commits into from
Oct 11, 2024
Merged

[BE] feat: 리뷰 모아보기 API 구현 #806

merged 41 commits into from
Oct 11, 2024

Commits on Oct 11, 2024

  1. refactor: dto 이름 변경 

    AnswerContentResponse -> TextResponse
    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    cdb2784 View commit details
    Browse the repository at this point in the history

  2. feat: 질문ID에 해당하는 Answer 반환 함수 추가

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    683cd59 View commit details
    Browse the repository at this point in the history

  3. feat: 질문ID에 해당하는 OptionItem들 반환 함수 추가

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    847b565 View commit details
    Browse the repository at this point in the history

  4. feat: 리뷰 요청 코드와 섹션ID에 해당하는 질문 반환 함수 추가

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    4d4cf04 View commit details
    Browse the repository at this point in the history

  5. feat: 리뷰 모이보기 API 구현

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    800345f View commit details
    Browse the repository at this point in the history

  6. refactor: 테스트에서 검증하고자 하는 것을 분명히

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    fb00e55 View commit details
    Browse the repository at this point in the history

  7. refactor: 패키지 의존 방향 통일을 위한 레포지토리 함수 이동

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    a786bf0 View commit details
    Browse the repository at this point in the history

  8. refactor: 테스트 목적에 해당하는 것만 남기기

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    6a173fc View commit details
    Browse the repository at this point in the history

  9. refactor: 함수 이름 변경 

    - 인자가 List<Long> 이므로, ids 로 끝나게 변경함
    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    98dd521 View commit details
    Browse the repository at this point in the history

  10. refactor: 가동성을 위한 함수 분리

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    a9b265e View commit details
    Browse the repository at this point in the history

  11. refactor: 다른 서비스 클래스들과 네이밍 통일

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    b4d951e View commit details
    Browse the repository at this point in the history

  12. feat: 리뷰 요청 코드 검증, 섹션 아이디 검증 추가

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    219dc1a View commit details
    Browse the repository at this point in the history

  13. refactor: 섹션에 해당하는 질문 가져오는 함수 수정 

    AS-IS: 내 리뷰그룹 중 특정 세션에 대한 질문 가져오기
TO-BE: 리뷰그룹 검증 완료되었으므로 특정 세션에 대해서만 가져오도록 수정
    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    97e91ef View commit details
    Browse the repository at this point in the history

  14. refactor: 답변 가져오는 함수 수정 

    AS-IS: 특정 질문에 대해서 답변된 것 다 받아오기
TO-BE: 내 리뷰 그룹에 해당한다는 조건 추가
    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    a97fe47 View commit details
    Browse the repository at this point in the history

  15. feat: 답변하지 않은 내용은 빈 배열로 받아오도록 하는 기능 추가

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    c7c9c7b View commit details
    Browse the repository at this point in the history

  16. fix: 깨지는 테스트 코드 봉합

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    2088cf1 View commit details
    Browse the repository at this point in the history

  17. refactor: Mapper 분리

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    e8f91be View commit details
    Browse the repository at this point in the history

  18. refactor: 섹션 검증 방법 변경 

    AS-IS: boolean 으로 검증, sectionId 인자 그대로 사용
TO-BE: Optional<Section>으로 검증, section.getId() 사용
    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    3da45ef View commit details
    Browse the repository at this point in the history

  19. refactor: 필요없는 JOIN 제거

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    be44806 View commit details
    Browse the repository at this point in the history

  20. test: 테스트 코드 목적별로 분리

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    4fb46d4 View commit details
    Browse the repository at this point in the history

  21. feat: 질문 목록을 position 순서대로 정렬

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    e4e3bdc View commit details
    Browse the repository at this point in the history

  22. refactor: 테스트 코드 extracting 사용 변경 

    AS-IS: attribute 값을 문자열로 하드코딩
TO-BE: dtp 의 필드명으로 가져오기 e.g. VoteResponse::content
    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    2bbdc85 View commit details
    Browse the repository at this point in the history

  23. chore: 오타 수정

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    91a0a82 View commit details
    Browse the repository at this point in the history

  24. test: 다른 리뷰 그룹이 있는 상황에 대한 테스트

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    0f3aec6 View commit details
    Browse the repository at this point in the history

  25. refactor: 접근제어자 수정

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    a484ec9 View commit details
    Browse the repository at this point in the history

  26. feat: 하이라이트 응답 추가

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    bb0c4ea View commit details
    Browse the repository at this point in the history

  27. test: 추가된 속성 반환 테스트

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    064f71e View commit details
    Browse the repository at this point in the history

  28. refactor: 유연한 레포지토리 함수로 변경

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    970e59c View commit details
    Browse the repository at this point in the history

  29. refactor: 변수명 변경

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    985959d View commit details
    Browse the repository at this point in the history

  30. refactor: 가독성 개선 

    함수 분리, 변수명 변경, 함수 인자 변경
    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    c80f961 View commit details
    Browse the repository at this point in the history

  31. refactor: Answer -> 구체Answer 캐스팅 예외 추가

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    c490a20 View commit details
    Browse the repository at this point in the history

  32. refactor: 서술형 답변 가져오는 함수 수정

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    50c2126 View commit details
    Browse the repository at this point in the history

  33. refactor: 선택지 목록 가져오는 함수 수정

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    3725edf View commit details
    Browse the repository at this point in the history

  34. test: reviewGatherMapper에 대한 테스트 작성

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    e37bda3 View commit details
    Browse the repository at this point in the history

  35. style: 개행 

    - 가독성 개선와 컨벤션 유지를 위함
    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    3eea7eb View commit details
    Browse the repository at this point in the history

  36. chore: 로그 메세지 수정 

    - 컨벤션 유지를 위함
    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    196f309 View commit details
    Browse the repository at this point in the history

  37. refactor: 컨트롤러 인자 타입 변경 

    - Long -> long
    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    1f9aec2 View commit details
    Browse the repository at this point in the history

  38. feat: 최대로 내려주는 응답 수 제한 기능 구현

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    8905a13 View commit details
    Browse the repository at this point in the history

  39. refactor: 테스트 코드 필드 접근제한자 추가

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    e8f0a40 View commit details
    Browse the repository at this point in the history

  40. refactor: 변수명 변경

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    d202f58 View commit details
    Browse the repository at this point in the history

  41. chore: 사용하지 않는 메서드 제거

    @nayonsoso
    nayonsoso committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    8a8ce13 View commit details
    Browse the repository at this point in the history