Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE] feat: 형광펜 모드 on/off 표시 메세지 추가 #823

Merged
merged 1 commit into from
Oct 11, 2024
Merged

[FE] feat: 형광펜 모드 on/off 표시 메세지 추가 #823

merged 1 commit into from
Oct 11, 2024

Conversation

BadaHertz52
Copy link
Contributor

@BadaHertz52 BadaHertz52 commented Oct 11, 2024 •
edited
Loading

🚀 어떤 기능을 구현했나요 ?

  • 사용자가 형광펜 모드를 인지하고 모드 ON/OFF을 알기 쉽도록 문구와 아이콘을 추가했어요

형광펜 모드 ON

image

형광펜 모드 OFF

image

🔥 어떻게 해결했나요 ?

📝 어떤 부분에 집중해서 리뷰해야 할까요?

  • 디자인,문구가 정해지지 않아 제가 임의로 만들었어요. 디자인 ,문구 보시고 수정 사항 있으면 알려주세요

📚 참고 자료, 할 말

@BadaHertz52 BadaHertz52 self-assigned this Oct 11, 2024
@BadaHertz52 BadaHertz52 linked an issue Oct 11, 2024 that may be closed by this pull request
[FE] 형광펜 작동 문구를 추가한다 #822
Closed
chysis
chysis approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@chysis chysis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

토글 버튼이 어떤 역할을 하는지 명확해졌네요👍

soosoo22
soosoo22 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@soosoo22 soosoo22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고했어요! 바다!

ImxYJL
ImxYJL approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@ImxYJL ImxYJL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

뒤늦게 이런 모양이 생각나긴 했는데... 단지 제안입니다ㅎㅎ 고생했어용용
image

@BadaHertz52 BadaHertz52 merged commit 0b2f228 into develop Oct 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chysis chysis chysis approved these changes

@soosoo22 soosoo22 soosoo22 approved these changes

@ImxYJL ImxYJL ImxYJL approved these changes

Assignees

@BadaHertz52 BadaHertz52

Labels
🍀 FE 🍰 초간단
Projects
2024-review-me
Status: Done
Milestone
6차 스프린트: 최종장
Development

Successfully merging this pull request may close these issues.

[FE] 형광펜 작동 문구를 추가한다
4 participants
@BadaHertz52 @chysis @soosoo22 @ImxYJL